studio icon indicating copy to clipboard operation
studio copied to clipboard

feat: Use Next.js in studio-next

Open KhudaDad414 opened this issue 2 years ago • 15 comments

Description

  • this PR ports the studio from CRA to Next.js.
  • it should compile and run in the dev environment.
  • It should build without issues.

Some known issues and possible improvements:

  • [ ] docker container file is missing in studio-next.
  • [ ] tests are missing in studio-next after NEXT.JS migration.
  • [ ] Code generation doesn't work in studio-next.
  • [ ] Use CodeMirror instead of Monaco.

fixes #684

KhudaDad414 avatar Apr 03 '24 21:04 KhudaDad414

🦋 Changeset detected

Latest commit: 68a61e9763abe27017c66b5925c651e0e61640bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
studio-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 03 '24 21:04 changeset-bot[bot]

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
Latest commit 68a61e9763abe27017c66b5925c651e0e61640bc
Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/664740c0dde50a000867c85c
Deploy Preview https://deploy-preview-1062--modest-rosalind-098b67.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 21:04 netlify[bot]

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
Latest commit 68a61e9763abe27017c66b5925c651e0e61640bc
Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/664740c03706430008fd2542
Deploy Preview https://deploy-preview-1062--asyncapi-studio-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 21:04 netlify[bot]

Deploy Preview for studio-next ready!

Name Link
Latest commit 68a61e9763abe27017c66b5925c651e0e61640bc
Latest deploy log https://app.netlify.com/sites/studio-next/deploys/664740c01adc340008c35af7
Deploy Preview https://deploy-preview-1062--studio-next.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 21:04 netlify[bot]

@KhudaDad414 Besides this PR, is anything else required to have Studio working on Next-JS ? I mean, If we merge this "today", will everything work out of the box?

smoya avatar Apr 10 '24 09:04 smoya

@smoya Yes, it should work as expected.

KhudaDad414 avatar Apr 16 '24 14:04 KhudaDad414

@smoya Yes, it should work as expected.

I hope this gets merged soon 🤞

smoya avatar Apr 16 '24 15:04 smoya

Looks like we don't have the logo, do you reproduce as well ? Screenshot 2024-04-22 at 15 29 18

Amzani avatar Apr 22 '24 13:04 Amzani

@Amzani it show up as expected now.

KhudaDad414 avatar Apr 26 '24 10:04 KhudaDad414

At a quick glance, I found some differences between versions.

The height of the app is not adjusted in the deploy preview. The Settings button is hidden unless you scroll down (at least in my native MacBook resolution). Same happens with the "errors" and "warnings" bar.

Current production version (https://studio.asyncapi.com): Google Chrome_Ni6BwwDx@2x

This new version (https://deploy-preview-1062--studio-next.netlify.app/):

Google Chrome_qlE6v65C@2x

The tooltips on the navigation bar differ from one version an the other:

Current production version (https://studio.asyncapi.com): Google Chrome_LeCqj1vz@2x

This new version (https://deploy-preview-1062--studio-next.netlify.app/): Google Chrome_PDZuR78z@2x

Additionally, font size or space differs from one version to the other:

Google Chrome_y8OM9V1b

smoya avatar Apr 29 '24 10:04 smoya

@smoya thanks for the review. 🙇 I can replicate the issues. will make the appropriate changes.

KhudaDad414 avatar Apr 29 '24 10:04 KhudaDad414

@smoya thanks for the review. 🙇 I can replicate the issues. will make the appropriate changes.

Nooice! BTW didnt test all functionalities, but just checked the appeal of the page. Meaning it could have more issues (or not).

smoya avatar Apr 29 '24 12:04 smoya

@smoya done. please take a look when you have the time.

KhudaDad414 avatar Apr 29 '24 12:04 KhudaDad414

Tested on my side, looks good so far. We should add some functional tests at some points using cypress, created a Pitch for it: https://github.com/asyncapi/studio/issues/1091

Amzani avatar Apr 29 '24 14:04 Amzani

/rtm

KhudaDad414 avatar May 17 '24 13:05 KhudaDad414