studio icon indicating copy to clipboard operation
studio copied to clipboard

[ADR-0006] Use PNPM package manager

Open KhudaDad414 opened this issue 1 year ago • 7 comments

Description

  • I propose we use pnpm instead of npm in studio

KhudaDad414 avatar Apr 03 '24 18:04 KhudaDad414

⚠️ No Changeset found

Latest commit: d1f901379aa46a6cff0103682c2ad29608f4fc57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 03 '24 18:04 changeset-bot[bot]

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
Latest commit d1f901379aa46a6cff0103682c2ad29608f4fc57
Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/662b884330a00f00084d95b8
Deploy Preview https://deploy-preview-1060--modest-rosalind-098b67.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 18:04 netlify[bot]

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
Latest commit d1f901379aa46a6cff0103682c2ad29608f4fc57
Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/662b8843f820d300087c1aa6
Deploy Preview https://deploy-preview-1060--asyncapi-studio-design-system.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 18:04 netlify[bot]

Deploy Preview for studio-next ready!

Name Link
Latest commit d1f901379aa46a6cff0103682c2ad29608f4fc57
Latest deploy log https://app.netlify.com/sites/studio-next/deploys/662b88434a8fba00088a1a0b
Deploy Preview https://deploy-preview-1060--studio-next.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 03 '24 18:04 netlify[bot]

We can add the pnpm-lock.yaml and pnpm-workspace_yaml as well.

The README should also be changed.

Shurtu-gal avatar Apr 03 '24 18:04 Shurtu-gal

@Shurtu-gal after we have an approval from other code-owners, I can move forward with an another PR implementing the change and making sure it works properly with Turborepo.

KhudaDad414 avatar Apr 04 '24 19:04 KhudaDad414

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 26 '24 10:04 sonarqubecloud[bot]

/rtm

KhudaDad414 avatar Apr 26 '24 12:04 KhudaDad414