spec icon indicating copy to clipboard operation
spec copied to clipboard

Published 20 hours ago • verified publisher icon asyncapi

feat: add googlepubsub bindings

Open whitlockjc opened this issue 1 year ago • 5 comments

Adds support for Google Cloud Pub/Sub to the Channel Binding Object and Message Binding Object lists.

Related issue(s): Bindings PR: https://github.com/asyncapi/bindings/pull/141 JSON Schema PR: https://github.com/asyncapi/spec-json-schemas/pull/253

whitlockjc avatar Sep 19 '22 20:09 whitlockjc

Added as pending candidate for 2.5 release - https://github.com/asyncapi/spec/issues/830

char0n avatar Sep 20 '22 12:09 char0n

@whitlockjc please also mention it under other bindings, even if for now they do not contain any official binding definition. It is for consistency, and to keep the word reserved for the same protocol along all bindings. Have a look at solace as example

also please list googlepubsub under protocols in Server Object

derberg avatar Sep 20 '22 14:09 derberg

@whitlockjc please also mention it under other bindings, even if for now they do not contain any official binding definition. It is for consistency, and to keep the word reserved for the same protocol along all bindings. Have a look at solace as example

also please list googlepubsub under protocols in Server Object

I'm not sure I follow. Does adding Google Cloud Pub/Sub bindings require a relating protocol? I assume that adding a new protocol would mean modifying the JSON Schemas PR as well?

whitlockjc avatar Sep 21 '22 18:09 whitlockjc

Done.

whitlockjc avatar Sep 21 '22 18:09 whitlockjc

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Sep 26 '22 08:09 sonarcloud[bot]

@char0n I think we are ready to merge this one. There was one merge conflict I had to solve manually, it was related to recent IBM MQ bug fix, addition of missing binding, and it was conflicting with new googlepubsub

derberg avatar Sep 26 '22 08:09 derberg

@derberg I'm a bit worried about the timing here. Merging this work will trigger rounds of work that would need to be done. Given that we're just days before the release deadline I would opt postponing (I'm not sure If I have this option) this work to the next release.

As far as I understand this would require providing implementation to parser-js, right @magicmatatjahu?

What do you think guys?

char0n avatar Sep 26 '22 09:09 char0n

@char0n there is no need to do anything in parser-js, so we just need to merge this one and https://github.com/asyncapi/spec-json-schemas/pull/253. There is also no need for any followup implementation in other AsyncAPI tools

derberg avatar Sep 26 '22 10:09 derberg

Yeah, as @derberg wrote, due to fact that bindings are "dynamic" objects and their shape is determined by binding's version, we treat bindings in tooling as raw JSON data - we don't have any models/api for bindings.

magicmatatjahu avatar Sep 26 '22 11:09 magicmatatjahu

@char0n so, are we merging? https://github.com/asyncapi/spec-json-schemas/pull/253 is approved, so all ready

derberg avatar Sep 26 '22 16:09 derberg

@derberg @magicmatatjahu thanks guys for explanations.

Merging.

char0n avatar Sep 27 '22 07:09 char0n

/rtm

char0n avatar Sep 27 '22 07:09 char0n

:tada: This PR is included in version 2.5.0-next-spec.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Sep 27 '22 07:09 asyncapi-bot