spec icon indicating copy to clipboard operation
spec copied to clipboard

docs: align wording with RFC 2119

Open char0n opened this issue 2 years ago • 1 comments

This is an editorial change, so sending against master branch.

Refs https://github.com/swagger-api/apidom/issues/1663

char0n avatar Jul 05 '22 14:07 char0n

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 05 '22 14:07 sonarqubecloud[bot]

Hi @dalelane, @derberg. Would you be able to look into this changeset? Thanks!

char0n avatar Sep 06 '22 11:09 char0n

@char0n because of other merges you need to solve some conflicts. Once you do it, you will need to ping all maintainers for review again, sorry

derberg avatar Sep 07 '22 14:09 derberg

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 07 '22 15:09 sonarqubecloud[bot]

@smoya @derberg @dalelane @fmvilas can you please re-review after merging changes from master?

char0n avatar Sep 07 '22 15:09 char0n

@derberg this is an editorial change. Can you merge to master please? Thanks!

char0n avatar Sep 09 '22 16:09 char0n

/rtm

fmvilas avatar Sep 09 '22 16:09 fmvilas

@char0n next time, you can merge it yourself :) Simply type /rtm or /ready-to-merge. Check https://github.com/asyncapi/community/blob/master/CONTRIBUTING.md#automation-around-the-process-of-merging-a-pull-request-pr.

fmvilas avatar Sep 09 '22 16:09 fmvilas

@fmvilas thanks, next time I'll know and bother you guys needlessly ;]

char0n avatar Sep 09 '22 17:09 char0n

Haha! Please do! :trollface:

fmvilas avatar Sep 09 '22 17:09 fmvilas

It sounded like a joke but what I really meant was and will not bother you guys needlessly ;]

char0n avatar Sep 09 '22 17:09 char0n

LOL nooo! I'm disappointed now 😂

fmvilas avatar Sep 09 '22 20:09 fmvilas

:tada: This PR is included in version 2.5.0-next-major-spec.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Sep 22 '22 13:09 asyncapi-bot

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

fmvilas avatar Sep 22 '22 14:09 fmvilas

:tada: This PR is included in version 2.5.0-next-spec.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Jan 31 '23 09:01 asyncapi-bot

Recent comments about the release from the bot were added by mistake. More details in https://github.com/asyncapi/spec/issues/899

derberg avatar Jan 31 '23 10:01 derberg