spec icon indicating copy to clipboard operation
spec copied to clipboard

feat!: release for version 3.0.0 of the spec

Open jonaslagoni opened this issue 3 years ago • 11 comments

This PR is created upfront to reflect on a daily basis what things are included in the release.

Also, the reason to create this PR a long time before the release is to enable automation (bot keeps upstream branches always up to date with master, see this action) that we have in place to regularly update the release branch with whatever is changed in the master branch. So nobody has to do it manually.

jonaslagoni avatar Apr 19 '22 08:04 jonaslagoni

/au

derberg avatar Apr 19 '22 08:04 derberg

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 21 '22 11:04 sonarqubecloud[bot]

I don't get why we are having those conflicts here. I expect these merges to apply without conflicts as there are no changes in this branch either.

smoya avatar Jun 13 '22 14:06 smoya

I wonder why this PR is having conflicts. I was looking at the changes in #807 and they all seem pretty straightforward to auto-merge for git but for some reason, it's not doing it.

fmvilas avatar Jun 13 '22 14:06 fmvilas

as there are no changes in this branch either

There are changes. In this branch, for instance, the examples are already "migrated" to version 3.0.0 and the spec already has the version number updated too. Still not enough to get this amount of conflicts IMO but worth mentioning.

fmvilas avatar Jun 13 '22 14:06 fmvilas

as there are no changes in this branch either

There are changes. In this branch, for instance, the examples are already "migrated" to version 3.0.0 and the spec already has the version number updated too. Still not enough to get this amount of conflicts IMO but worth mentioning.

Oh, yeah I didn't notice. Thanks for mentioning it.

smoya avatar Jun 13 '22 15:06 smoya

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 25 '22 16:07 sonarqubecloud[bot]

@jonaslagoni fyi there are many merge conflicts. Because of this, the bot cannot keep it up to date with master. This means workflows are not getting up to date, and this is why 3.0 release candidate was not now released after merging PR from @fmvilas

derberg avatar Sep 21 '22 12:09 derberg

Let me have a look. I'm gonna rebase and cherry-pick to try to clean the history. Let's see if it works.

fmvilas avatar Sep 21 '22 13:09 fmvilas

Alright, so I think I found the problem (or at least the PR that's causing the majority of them). #753 is changing a lot of files replacing 2.3.0 with 3.0.0. We do this on every minor release too so it's going to conflict every time we have a new release until we get 3.0.0. My suggestion is that we leave #753 out and we reapply it again when the time to release 3.0.0 arrives. Is everyone ok with this?

@jonaslagoni @derberg @dalelane

fmvilas avatar Sep 21 '22 14:09 fmvilas

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 09 '22 15:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 10 '23 15:03 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 02 '23 22:08 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 17 '23 22:09 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 04 '23 22:12 sonarqubecloud[bot]

Because of this issue, we need to manually merge this PR if we want to keep mentions to the co-authors of this PR.

So please, when merging, add the following commit message description literally (with the two empty lines at the beginning as well):



Co-authored-by: Sergio Moya <[email protected]>
Co-authored-by: nickshoe <[email protected]>
Co-authored-by: Rishi <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Heiko Henning <[email protected]>
Co-authored-by: Lukasz Gornicki <[email protected]>
Co-authored-by: samz <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: Vladimír Gorej <[email protected]>

smoya avatar Dec 04 '23 23:12 smoya

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Dec 05 '23 09:12 asyncapi-bot