parser-js icon indicating copy to clipboard operation
parser-js copied to clipboard

Document how to fix randomly failing tests during development

Open derberg opened this issue 3 years ago • 4 comments

Reason/Context

Sometimes on Windows tests fail. We fixed it on CI but contributors are still affected on local development.

Description

  • add an explanation to Develop section in the Readme
  • this is why user needs to do https://github.com/asyncapi/parser-js/blob/master/.github/workflows/if-nodejs-pr-testing.yml#L23-L27
  • explain when it is needed: "when you develop something in the parser and even though you did not make any changes affects tests, the tests are failing"

derberg avatar May 25 '22 11:05 derberg

/gfi docs

derberg avatar May 25 '22 11:05 derberg

Hey, @derberg I have documented the above points in the readme section in my forked repo, check once and let me know if that's what the issue is stating or if it needs any improvement further and I can make a final PR for the same.
https://github.com/Ruchip16/parser-js/blob/master/README.md/#develop

Ruchip16 avatar Aug 01 '22 17:08 Ruchip16

Hey @Ruchip16, @derberg is on vacation at the moment, so I am jumping in if you don't mind?

Since you have already commited the changes to your branch, can I get you to create a PR? That way it is easier to see the changes you propose and we can review/discuss it directly 🙂 It's the easiest way to get feedback 👍

Let me know if you have any issue creating one!

jonaslagoni avatar Aug 01 '22 20:08 jonaslagoni

Yess @jonaslagoni suree, I have made a PR, check it once and let me know if it needs any improvement further

Ruchip16 avatar Aug 02 '22 05:08 Ruchip16

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Dec 01 '22 00:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Apr 20 '23 00:04 github-actions[bot]

:tada: This issue has been resolved in version 2.1.0-next-major-spec.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Jul 14 '23 10:07 asyncapi-bot

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Aug 03 '23 07:08 asyncapi-bot