parser-js icon indicating copy to clipboard operation
parser-js copied to clipboard

fix: parser will throw an error when address is null/no param but param is present

Open ibishal opened this issue 1 year ago • 10 comments

Description

Now when there is parameter but the address not contain any, then it will throw an error

Related issue(s) Fixes #875

ibishal avatar Jun 11 '24 22:06 ibishal

@ibishal the Spectral rule should apply for AsyncAPI spec v3. Not necessary for v2 (unless no cost of adding)

smoya avatar Jun 17 '24 14:06 smoya

FYI @ibishal, this PR is part of https://github.com/asyncapi/parser-js/issues/1019 and by that, part of this Bounty Program issue. If you want to participate in the Bounty Program and get a reward ($), please express your interest in https://github.com/asyncapi/parser-js/issues/1016 and include an outline of the work you will do for each of the rules that should be added.

smoya avatar Jun 17 '24 14:06 smoya

FYI @ibishal, this PR is part of #1019 and by that, part of this Bounty Program issue.

i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?

If you want to participate in the Bounty Program and get a reward ($), please express your interest in #1016 and include an outline of the work you will do for each of the rules that should be added.

i have sent a basic outline in slack(dms), should i put it in the issue too(more briefly outlining each rules) cc @smoya

ibishal avatar Jun 17 '24 14:06 ibishal

i have created this PR solving the issue #875 (it is overlapping with issue #1019 )

One is a bug, the other is the issue that mentions to work on such a bugfix as part of the bounty program.

i had created this PR solving the issue #875 (it is overlapping with issue #1019 ), should i close this ?

You should follow standard procedures. Express your desire of working on such an issue, say how would you do with each of the tasks that are part of the bounty issue and not only with one. I will choose the right person based on that info.

smoya avatar Jun 17 '24 14:06 smoya

Are you gonna include the rule for v3?

smoya avatar Jun 20 '24 12:06 smoya

@smoya should I ?,see the comment made by @aeworxet in the bounty issue

ibishal avatar Jun 20 '24 14:06 ibishal

@smoya should I ?,see the comment made by @aeworxet in the bounty issue

Of course, you can work in any of the issues you want, that doesn't mean it is assigned to you. We only assign issues in programs such as Bounty, GSoC, etc.

Meaning other people is also free to work in the same one and send a PR in parallel.

smoya avatar Jun 20 '24 15:06 smoya

@smoya this PR is ready for review

ibishal avatar Jun 20 '24 16:06 ibishal

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Oct 19 '24 00:10 github-actions[bot]

@ibishal

@smoya this PR is ready for review

A PR cannot be considered ready for review while it has failing tests and conflicts.

aeworxet avatar Dec 05 '24 04:12 aeworxet

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Apr 06 '25 00:04 github-actions[bot]