modelina icon indicating copy to clipboard operation
modelina copied to clipboard

Add End to End test so we ensure users can use @asyncapi/modelina npm package.

Open smoya opened this issue 4 years ago • 6 comments

Reason/Context

Recently I tried to run the example located at https://github.com/asyncapi/modelina#example with no success. When compiling TS, I got the few errors. The issue behind was fixed (thanks to super fast @magicmatatjahu ⚡ ) by https://github.com/asyncapi/modelina/pull/290 but also https://github.com/asyncapi/modelina/pull/292, https://github.com/asyncapi/modelina/pull/294 and https://github.com/asyncapi/modelina/pull/297.

The point is that I, as a user, couldn't run the example at all. Meaning more users like me, were not able to use Modelina either.

I suggest we run a test testing @asyncapi/modelina module through the example, running it from a user point of view so we ensure Modelina can, at least, be used by any user and new releases don't break it.

Description

A test that creates a simple project, installs modelina npm package (from local code) and compiles the TS example. More details and suggestions:

  • Build the project a
  • Move the example from the README.md to it's own file so we can reuse it in this test.
  • a tsconfig.json file like https://gist.github.com/ccnokes/e8c419e2874111c5ef41cc1442680acb should be enough.
  • tsc -p tsconfig.json command should exit with code zero. Js file should be there.

smoya avatar Jul 07 '21 10:07 smoya

This issue has been automatically marked as stale because it has not had recent activity :sleeping: It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation. Thank you for your contributions :heart:

github-actions[bot] avatar Sep 06 '21 00:09 github-actions[bot]

I think we can close this issue now with the introduction of example tests - https://github.com/asyncapi/modelina/tree/master/examples. Thoughts @smoya?

jonaslagoni avatar Sep 22 '21 11:09 jonaslagoni

I think we can close this issue now with the introduction of example tests - https://github.com/asyncapi/modelina/tree/master/examples. Thoughts @smoya?

What do you mean by example tests? Are we running a full end to end test where we compile modelina from source code?

smoya avatar Sep 22 '21 15:09 smoya

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar May 14 '22 00:05 github-actions[bot]

What do you mean by example tests? Are we running a full end to end test where we compile modelina from source code?

Hmm, I guess we arent no 🤔

jonaslagoni avatar May 16 '22 09:05 jonaslagoni

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Sep 14 '22 00:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Feb 10 '23 00:02 github-actions[bot]

With the new example tests and black box tests, I would comfortably say we have as much end-to-end tests and we possibly can 😄

Closing this issue.

jonaslagoni avatar Feb 13 '23 02:02 jonaslagoni