modelina icon indicating copy to clipboard operation
modelina copied to clipboard
verified publisher icon asyncapi

fix: updated unit-tests to test round-trip serialization.

Open RowlandBanks opened this issue 1 year ago • 5 comments

Description

  • Adds a new unit-test proving a model can be round-tripped ✔️
  • Fixes any bugs encountered ✔️

Related Issue

Fixes #1832

Checklist

  • [ ] The code follows the project's coding standards and is properly linted (npm run lint).
  • [ ] Tests have been added or updated to cover the changes.
  • [ ] Documentation has been updated to reflect the changes.
  • [ ] All tests pass successfully locally.(npm run test).

Additional Notes

RowlandBanks avatar Feb 26 '24 14:02 RowlandBanks

Deploy Preview for modelina canceled.

Name Link
Latest commit 3816e7c6888fa29ad66872ff74f4c02afa49591e
Latest deploy log https://app.netlify.com/sites/modelina/deploys/65ddfb07d396db000834f1c2

netlify[bot] avatar Feb 26 '24 14:02 netlify[bot]

Pull Request Test Coverage Report for Build 8066939011

Details

  • -1 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.283%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/csharp/presets/JsonSerializerPreset.ts 7 8 87.5%
<!-- Total: 7 8
Totals Coverage Status
Change from base Build 8062206205: -0.02%
Covered Lines: 5998
Relevant Lines: 6330
💛 - Coveralls

coveralls avatar Feb 27 '24 12:02 coveralls

Gonna take a look after some lunch :v:

jonaslagoni avatar Feb 27 '24 13:02 jonaslagoni

Quality Gate Failed Quality Gate failed

Failed conditions
24.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 27 '24 15:02 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]