modelina icon indicating copy to clipboard operation
modelina copied to clipboard

Add loading animation for when playground generate models

Open jonaslagoni opened this issue 1 year ago • 19 comments

Reason/Context

https://modelina.org/playground

When you change the input, open the playground, or change the settings, the playground need to ask the backend to re-generate the models, and there can be a significant delay here depending on input and latency to the backend server. Therefore I suggest we add a loading screen to the output models view that showcases that it is currently in the process of being generated.

You can find the most relevant code for the playground here: https://github.com/asyncapi/modelina/blob/master/modelina-website/src/components/playground/Playground.tsx

And the output panel can be found here: https://github.com/asyncapi/modelina/blob/master/modelina-website/src/components/playground/OutputNavigation.tsx

jonaslagoni avatar Jan 04 '24 21:01 jonaslagoni

@jonaslagoni working on this

Gmin2 avatar Jan 05 '24 10:01 Gmin2

@jonaslagoni we want to add the loading screen in the output models only or in the whole screen ?

Gmin2 avatar Jan 08 '24 15:01 Gmin2

To me just the output models make sense to me, cause then the user can still change settings and input

@devilkiller-ag what do you think? 🤔

jonaslagoni avatar Jan 08 '24 18:01 jonaslagoni

To me just the output models make sense to me, cause then the user can still change settings and input

@devilkiller-ag what do you think? 🤔

I also think that showing the loader on the output screen only will make more sense.

devilkiller-ag avatar Jan 08 '24 18:01 devilkiller-ag

check the PR added the loader in the output screen only

cc @jonaslagoni @devilkiller-ag

Gmin2 avatar Jan 08 '24 18:01 Gmin2