html-template
html-template copied to clipboard
remove puppeteer from dependencies
Reason/Context
Please try answering few of those questions
- Why we need this improvement? puppeteer is used only for PDF generation while being quite heavy (~200Mb)
- How will this change help? download time will be increased drastically
- What is the motivation? PDF generation is not used very often and for users that are not using it at all 200Mb overhead is way too much
Description
Please try answering few of those questions
- What changes have to be introduced? remove puppeteer from dependencies
- Will this be a breaking change? yes
- How could it be implemented/designed? change PDF generation function to accept puppeteer instance as a parameter. In that case, users that need PDF will have to install puppeteer separately and pass it as an argument