generator icon indicating copy to clipboard operation
generator copied to clipboard

Complete Nunjuck and `ag` deprecation -> remove it

Open derberg opened this issue 4 months ago • 12 comments

Nunjucks is deprecated: https://github.com/asyncapi/generator/issues/1255 ag cli is deprecated: https://github.com/asyncapi/generator/issues/1229

  • all nunjuck code must be removed from apps/generator
  • remove apps/nunjucks-filters and deprecate in npm
  • remove all ag related code
  • make sure react engine is now treated as default (meaning nobody have to point to it in the template config)
  • lots of cleanup in docs - not just removal of specific nunjucks docs, but probably refactor of few existing docs
  • introduce code or just clear dev guide that still supports local development for templates developers - so it is easy for them to run template through generation process without writing tests and making any hacks to be able to run it through AsyncAPI CLI
  • work with AsyncAPI CLI maintainers as this is a MAJOR release, a breaking change and we need to know how to get in into CLI (CLI already supports 2 generator versions - this probably should change)

I'll work on it. Work must take place not sooner than November.

Doing it all in one PR might be hard. Might be a feature branch will be needed.

It is an advanced issue, actually beyond advanced but 🤷🏼 all must be done as one effort

derberg avatar Sep 11 '25 08:09 derberg

Bounty Issue's service comment

Text labels: bounty/2025-Q4, bounty/advanced, bounty/coding First assignment to regular contributors: 2025-09-19 00:00:00 UTC+12:00 End Of Life after: 2025-10-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

aeworxet avatar Sep 15 '25 12:09 aeworxet

@derberg can I work on this?

MAVRICK-1 avatar Sep 15 '25 16:09 MAVRICK-1

it's complex task with lots of insider knowlege - typical issue for maintainers. I'm going to work on it

derberg avatar Sep 15 '25 16:09 derberg

Following the expression of desire to work on this Bounty Issue, @derberg (githubID: 6995927) is an AsyncAPI Maintainer specified in the file https://github.com/asyncapi/community/blob/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

aeworxet avatar Sep 16 '25 07:09 aeworxet

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2025-09-16 2025-10-06 2025-11-30 2025-10-26 2025-11-16 2025-11-30
Please note that the dates given represent deadlines, not specific dates; so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Assignee: @derberg (githubID: 6995927)

aeworxet avatar Sep 16 '25 07:09 aeworxet

@derberg (githubID: 6995927), please provide the Draft PR of the Bounty Issue.

aeworxet avatar Oct 28 '25 12:10 aeworxet

it is designed to be done later, as in description Work must take place not sooner than November

derberg avatar Oct 28 '25 12:10 derberg

started working on this one.

first need this https://github.com/asyncapi/generator/pull/1754

derberg avatar Nov 13 '25 17:11 derberg

Due to an active cybersecurity incident https://www.aikido.dev/blog/shai-hulud-strikes-again-hitting-zapier-ensdomains https://asyncapi.slack.com/archives/C34F2JV0U/p1763978529783109 https://github.com/asyncapi/website/pull/4640

which requires significant time and resources for immediate mitigation and lacks a clear timeframe for a final resolution that will prevent recurrence, the Timeline of this Bounty Issue is frozen for an indefinite amount of time.

aeworxet avatar Nov 26 '25 08:11 aeworxet

PR submitter to reviewers

TODO afer merge:

  • deprecate https://hub.docker.com/r/asyncapi/generator and point to CLI
  • deprecate https://www.npmjs.com/package/@asyncapi/nunjucks-filters and point to release notes

derberg avatar Dec 08 '25 16:12 derberg

preparing work in CLI: https://github.com/asyncapi/cli/pull/1919

derberg avatar Dec 11 '25 17:12 derberg

This Bounty Issue is currently in its final stages, undergoing the final reviews.

aeworxet avatar Dec 12 '25 12:12 aeworxet

working on final task https://github.com/asyncapi/cli/pull/1919

derberg avatar Dec 16 '25 15:12 derberg

in theory it is completed - only problem is that CLI releases are broken atm (escalated to NPM), so https://github.com/asyncapi/cli/pull/1919 was not released properly

derberg avatar Dec 18 '25 11:12 derberg

I would suggest still waiting for the release and checking the released CLI's functionality to ensure this Bounty Issue is factually completed.

aeworxet avatar Dec 19 '25 02:12 aeworxet