generator icon indicating copy to clipboard operation
generator copied to clipboard

[Test]: Add `FileHeaderInfo.test.js` for python websocket client

Open Adi-204 opened this issue 8 months ago • 9 comments

FileHeaderInfo component has conditions in implementation so we can include test for it.

Adi-204 avatar Mar 27 '25 08:03 Adi-204

Waiting for approval from maintainers thanks : )

Adi-204 avatar Mar 27 '25 08:03 Adi-204

change of scope

  • FileHeaderInfo.test.js from javascript client folders should be removed
  • FileHeaderInfo.js from python and javascript client folders should be removed
  • new FileHeaderInfo.js must be added to https://github.com/asyncapi/generator/tree/master/packages/components/src/components
  • new FileHeaderInfo.test.js added to https://github.com/asyncapi/generator/tree/master/packages/components/test/components

success is when single new FileHeaderInfo.js is used in both:

  • https://github.com/asyncapi/generator/blob/master/packages/templates/clients/websocket/javascript/template/client.js.js
  • https://github.com/asyncapi/generator/blob/master/packages/templates/clients/websocket/python/template/client.py.js

derberg avatar Apr 15 '25 15:04 derberg

@AdeebaNizam404 please have a look

derberg avatar Apr 15 '25 15:04 derberg

Acknowledged, will start working on it

AdeebaNizam404 avatar Apr 15 '25 23:04 AdeebaNizam404

/gfi js

Adi-204 avatar Jun 09 '25 16:06 Adi-204

Please notice their is change of scope of this issue. Don't focus on issue title and description. The issue description is https://github.com/asyncapi/generator/issues/1447#issuecomment-2806559511 you can take PR - https://github.com/asyncapi/generator/pull/1519 as reference because it is almost correct, just ignore the extra changes done in that PR outside scope of the issue.

Adi-204 avatar Jun 12 '25 05:06 Adi-204

@Adi-204 can i work on this

blazethunderstorm avatar Jun 21 '25 22:06 blazethunderstorm

@blazethunderstorm you can wok on it. I hope you read - https://github.com/asyncapi/generator/issues/1447#issuecomment-2965124421

Adi-204 avatar Jun 22 '25 05:06 Adi-204

@Adi-204 yeah would keep that in mind

blazethunderstorm avatar Jun 22 '25 07:06 blazethunderstorm

@blazethunderstorm are you still working on the issue? Just wanted to confirm.

Adi-204 avatar Jun 30 '25 11:06 Adi-204

@Adi-204 yeah sry was sick for past few days would make its pr in a day

blazethunderstorm avatar Jun 30 '25 11:06 blazethunderstorm

@blazethunderstorm it's fine take your time.

Adi-204 avatar Jun 30 '25 11:06 Adi-204