asyncapi
[BUG] Slack groups are not updated
Describe the bug.
When a repo is removed from the list of repos of a user in the MAINTAINERS.yaml file, the Slack user groups are not updated. For instance, I was a maintainer of the website repository and, therefore, I was added as part of the @maintainers_website Slack group. However, I stopped being a maintainer of the website repo but I'm still part of the @maintainers_website Slack group.
Expected behavior
If a user removes a repo from their list, they should also be removed from the correspondent @maintainers_[repo] Slack group.
Screenshots
No relevant screenshots.
How to Reproduce
Explained in the description above.
🥦 Browser
None
👀 Have you checked for similar open issues?
- [x] I checked and didn't find similar issue
🏢 Have you read the Contributing Guidelines?
- [x] I have read the Contributing Guidelines
Are you willing to work on this issue ?
No, someone else can work on it
I'm labeling as good first issue not because it's an easy-to-solve bug in terms of coding experience but because it's a good way to get familiar with how automation works in AsyncAPI.
more details about current automation: https://github.com/asyncapi/community/blob/master/.github/workflows/slack/README.md?plain=1
Just putting the docs here, if somebody plans to take it up: https://github.com/pablovarela/terraform-provider-slack/blob/master/docs/resources/usergroup.md
As well as the related workflow: https://github.com/asyncapi/community/blob/master/.github/workflows/slack-integration.yml
@derberg @Shurtu-gal can you please assign me this issue. It will be great starting issue for me
Issues are not assigned except for bounty and mentorship ones. Feel free to submit a PR.
Also was just looking through the action logs. I thing format of couple of files have changed. Need to fix that.
Hey @fmvilas @Shurtu-gal I think i have a solution for this. I am thinking of making update-slack.yaml file and a python script. The python script will handle all the logic of this task. Am I in the right direction??? Your suggestions will be really helpful
Also was just looking through the action logs. I thing format of couple of files have changed. Need to fix that.
Looking thorough logs and inspecting the cause seems that terraform init is failing. Looks like ubuntu removed terraform support form their latest 24.04 as seen here
To fix it we can setup terraform separately.
I honestly have no idea about the underlying issue. Just came here to say that OpenTofu is now the OSS version of Terraform and we might have to switch to it instead.
@Shurtu-gal going through current slack groups implementation and also the terraform docs i think implementation is fine but the reason @fmvilas faced this issue is due to deployment issue occurring due to missing terraform dependency in ubuntu-latest.
For PR of this issue should i go with a temporary fix to install terraform or go with the opensource version implementation of terraform which is suggested above.
Let me know you thoughts on this. Thanks.
@Shurtu-gal digging more into the issue i found this issue which suggests to use hashicorp/setup-terraform@v3 action.
Should i raise a PR using that to setup terraform?
Please update. Thanks.
@Shurtu-gal digging more into the issue i found this issue which suggests to use
hashicorp/setup-terraform@v3 action. Should i raise a PR using that to setup terraform?Please update. Thanks.
Yes, please. Just remember to test it out by making a slack workspace and running the workflow.
@Shurtu-gal digging more into the issue i found this issue which suggests to use
hashicorp/setup-terraform@v3 action. Should i raise a PR using that to setup terraform?Please update. Thanks.
Yes, please. Just remember to test it out by making a slack workspace and running the workflow.
Sure will raise a pr with fix 👍🏻.
Pin pointed the issue what I think is with the recent addition of Ambassadors slack was not added.
Like: https://github.com/asyncapi/community/blob/2be75a694b9c6f80ecd305d4b6c7312674a63cb4/MAINTAINERS.yaml#L714
Hence workflow is failing.
cc: @derberg @neoandmatrix
Pin pointed the issue what I think is with the recent addition of Ambassadors slack was not added.
Like:
Line 714 in 2be75a6
- name: Akshaya Gurlhosur Hence workflow is failing.
Humm, Yes this seems the issue as the same code and a subset of MAINTAINERS.yaml file i had used in my local testing and it had worked flawlessly.
And there are even some more entries with same issue.
Yeah, this was just an example. For now you can start with a draft PR using ifContains like done for repos.
Yeah, this was just an example. For now you can start with a draft PR using ifContains like done for repos.
Okay will raise a draft PR with this approach. Thanks @Shurtu-gal for guidance. 👍🏻
Just had a doubt @Shurtu-gal The entries not having slack field means that those members aren't to be added to slack. Am i correct?
Just had a doubt @Shurtu-gal The entries not having slack field means that those members aren't to be added to slack. Am i correct?
Depends @derberg would need to take a stance here.
yeah, I mean, our stand is, Slack is optional like any other channel, nobody can be forced to use it - so if no Slack ID, then ignore
yeah, I mean, our stand is, Slack is optional like any other channel, nobody can be forced to use it - so if no Slack ID, then ignore
Thanks for clarification. Will raise a PR with fix.
Were there any changes to channels in slack recently?
https://github.com/asyncapi/community/actions/runs/13129999529
Were there any changes to channels in slack recently?
https://github.com/asyncapi/community/actions/runs/13129999529
Looking at the errors and some searching in the official docs the error which we are getting account_inactive looks like is related to permissions and token according to this https://api.slack.com/methods/apps.connections.open#errors.
What do you think @Shurtu-gal
Imo it is most probably due to those channels not being there.
Huum was searching for the channel IDs which were failing but of all i searched all the channels were there like
#linux
And also IDs too were matching so i guess channels are there and something else might be issue.
Altough my this is just my view based on what i found and might be completely wrong so any guidance on what i should proceed further with this issue or where might to look will be extremely helpful to me.
Thnaks.
cc: @Shurtu-gal
@Shurtu-gal Any thoughts or suggestions as to where i should proceed with this issue further.
Thanks.
I also don't know at this point. Would need to do a manual resolution between tf-lock. And can only be done by some admin. 🤷🏻
I also don't know at this point. Would need to do a manual resolution between tf-lock. And can only be done by some adming. 🤷🏻
Huum i also tried to reproduce the issue with my test workspaces but unfortunately was unable to do so. Will try to debug further if possible and will update if able to find something.
Thanks for clarification.