cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon asyncapi

fix: make sure validation of invalid document exits `1`

Open shawakash opened this issue 2 years ago • 4 comments

Description

  • Fixes the issue #861 having validation exit code error by checking the return status
  • Added a enum for validation return status

Related issue(s) Resolves #861

shawakash avatar Nov 04 '23 15:11 shawakash

@smoya @Souvikns Please review it

shawakash avatar Nov 04 '23 15:11 shawakash

@shawakash there are some lint issues.

Souvikns avatar Nov 29 '23 09:11 Souvikns

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 01 '23 04:12 sonarqubecloud[bot]

@Souvikns fixed the lint issue

shawakash avatar Dec 01 '23 04:12 shawakash

@Souvikns @derberg Should we close this PR as the bug related is already solved by https://github.com/asyncapi/cli/pull/1068 ?

peter-rr avatar Mar 21 '24 20:03 peter-rr

We can close it, but this PR adds some refactoring, that we can use.

Souvikns avatar Mar 22 '24 09:03 Souvikns

We can close it, but this PR adds some refactoring, that we can use.

@Souvikns Yeah, we can keep it as a refactor then. Should we change the PR title from fix: to refactor: in that case?

@shawakash Do you need some help to move forward with this PR?

peter-rr avatar Mar 22 '24 17:03 peter-rr

there are conflicts so I suggest you @peter-rr to open separate PR with refactor

derberg avatar Apr 10 '24 12:04 derberg