cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: add support for diff markdown output

Open aayushmau5 opened this issue 2 years ago • 2 comments

Description

  • This PR adds support for Markdown output by diff that has been added recently in the diff library.
  • Currently, the markdown output is printed to stdout

aayushmau5 avatar Jun 21 '22 08:06 aayushmau5

~~Created a draft PR for now. Have to make the tests better, and refactor some things.~~ Done :D

aayushmau5 avatar Jun 21 '22 08:06 aayushmau5

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Jul 21 '22 09:07 sonarcloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Dec 03 '22 00:12 sonarcloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Feb 13 '23 07:02 sonarcloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Mar 27 '23 07:03 sonarcloud[bot]

@aayushmau5 some tests related to diff are failing, don't think it is random stuff

derberg avatar Mar 27 '23 07:03 derberg

@derberg will check and fix! Thanks for the heads up.

aayushmau5 avatar Mar 27 '23 08:03 aayushmau5

@aayushmau5 yo, I suggest resolving conflicts and updating to latest master as lots of random issues in flaky tests were fixed, and all should be good here after update

derberg avatar Apr 24 '23 13:04 derberg

@derberg will do. Was fixing the tests, but some tests were timing out locally. Hopefully the latest master will have this fix.

aayushmau5 avatar Apr 26 '23 11:04 aayushmau5

@aayushmau5 can you let me know if you are facing the same issues with the tests now?

Souvikns avatar Jun 14 '23 09:06 Souvikns

@Souvikns fixed all the tests. No sure what to do with sonar. As you can see, I spent the last 2 hours fighting with it xD

I think the duplication is necessary. Either we can ignore it somehow or try to find better way to store test outputs.

aayushmau5 avatar Jun 17 '23 19:06 aayushmau5

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Jun 27 '23 13:06 sonarcloud[bot]

/rtm

derberg avatar Jun 27 '23 16:06 derberg

/rtm

derberg avatar Jun 28 '23 10:06 derberg