cli icon indicating copy to clipboard operation
cli copied to clipboard

Fetching examples from master causes errors during release

Open derberg opened this issue 3 years ago • 5 comments

Describe the bug

because of

const SPEC_EXAMPLES_ZIP_URL = 'https://github.com/asyncapi/spec/archive/refs/heads/master.zip';

that is in https://github.com/asyncapi/cli/blob/master/scripts/fetch-asyncapi-example.js#L9 script, we will always have few hours during spec release where CLI will fail in development, on ci/cd. It is because it is fetching stuff from master, that was already released, like now, we released spec 2.3. But CLI is not updated with parser that supports 2.3 cause it is not yet released

so we need to use:

const SPEC_EXAMPLES_ZIP_URL = 'https://github.com/asyncapi/spec/archive/refs/tags/v2.2.0.zip';

but then it means we have to have a manual bump of CLI, unless we improve the script to somehow check what version it should fetch. Like maybe use parser before fetching, to check what is the latest version of the spec that it is using 🤔

derberg avatar Jan 31 '22 15:01 derberg

Hey @derberg I hope this fix works : #213

imabp avatar Feb 06 '22 18:02 imabp

Hey @derberg The latest release of cli (v0.13.0 ), supports parser version 1.14.0 which supports the spec version 2.3.0 If we are following this pattern.

parser spec
1.13.x 2.2.x
1.14.x 2.3.x

Using this pattern, MAJOR.MINOR.PATCH it seems

for every MINOR update in spec, there is MINOR update required for parser. And if we stay consistent with this approach, we can implement the script in that logic.

imabp avatar Feb 07 '22 08:02 imabp

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jun 08 '22 00:06 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Oct 07 '22 00:10 github-actions[bot]

@imabp do you plan to continue working on this one? https://github.com/asyncapi/cli/pull/213

derberg avatar Oct 11 '22 11:10 derberg