feat: asyncapi on alpine distros
Description
Added dockerignore and copying only necessary files in Dockerfile
Related issue(s) Fixes #1798
Inspired from https://github.com/asyncapi/cli/issues/1800#issuecomment-2980227688
🦋 Changeset detected
Latest commit: a9351cb98960f5c4fc4ee0f423a39fc34a36eb83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @asyncapi/cli | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Changeset has been generated for this PR as part of auto-changeset workflow.
Please review the changeset before merging the PR.
---
'@asyncapi/cli': minor
---
feat: asyncapi on alpine distros
- de8e46a: feat: asyncapi on alpine distros
- 18f34d2: refactor: added dockerignore and improved Dockerfile
- d0141a8: fix: update dockerfile and lock file and not include lock file in pre commit hooks
- dc87fff: fix: update dockerfile and dockerignore to new github-action dockerfile
If you are a maintainer or the author of the PR, you can change the changeset by clicking here
[!TIP] If you don't want auto-changeset to run on this PR, you can add the label
skip-changesetto the PR or remove the changeset and change PR title to something other thanfix:orfeat:.
Hey @Gmin2 I really like this, I have a few suggestions/doubts if you don't mind.
- Use COPY --chown=asyncapi:asyncapi instead of running chown -R after copying.
- Include summary details of runtime to show the optimizations.
- In .dockerignore, can we keep lockfile for reproducible builds?
@asyncapi/bounty_team
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
can i have a review on this , idk why the test is broken here?
can i have a review on this , idk why the test is broken here?
Upon viewing the changed files 2 files i found are in the PR but not required in my opinion:-
- As there are no new dependencies being added nor any change to package.json is there then i believe there should also be no lockfile change.
- The lefthook change is probably not needed.
CC:- @AayushSaini101 @Shurtu-gal @Souvikns
@Shurtu-gal can you take a look at this? thanks : )
Also there is conflict with package-lock. Tests should ideally pass upon pushing new commit.
As @Gmin2 has not provided any updates since > 2 months. Proceeding to close the PR.