cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: asyncapi on alpine distros

Open Gmin2 opened this issue 4 months ago • 9 comments

Description

Added dockerignore and copying only necessary files in Dockerfile

Related issue(s) Fixes #1798

Inspired from https://github.com/asyncapi/cli/issues/1800#issuecomment-2980227688

Gmin2 avatar Aug 26 '25 18:08 Gmin2

🦋 Changeset detected

Latest commit: a9351cb98960f5c4fc4ee0f423a39fc34a36eb83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 26 '25 18:08 changeset-bot[bot]

Changeset has been generated for this PR as part of auto-changeset workflow.

Please review the changeset before merging the PR.
---
'@asyncapi/cli': minor
---

feat: asyncapi on alpine distros

- de8e46a: feat: asyncapi on alpine distros
- 18f34d2: refactor: added dockerignore and improved Dockerfile
- d0141a8: fix: update dockerfile and lock file and not include lock file in pre commit hooks
- dc87fff: fix: update dockerfile and dockerignore to new github-action dockerfile

If you are a maintainer or the author of the PR, you can change the changeset by clicking here

[!TIP] If you don't want auto-changeset to run on this PR, you can add the label skip-changeset to the PR or remove the changeset and change PR title to something other than fix: or feat:.

github-actions[bot] avatar Aug 26 '25 18:08 github-actions[bot]

Hey @Gmin2 I really like this, I have a few suggestions/doubts if you don't mind.

  • Use COPY --chown=asyncapi:asyncapi instead of running chown -R after copying.
  • Include summary details of runtime to show the optimizations.
  • In .dockerignore, can we keep lockfile for reproducible builds?

Saru2003 avatar Aug 27 '25 13:08 Saru2003

@asyncapi/bounty_team

aeworxet avatar Sep 01 '25 02:09 aeworxet

can i have a review on this , idk why the test is broken here?

Gmin2 avatar Sep 10 '25 07:09 Gmin2

can i have a review on this , idk why the test is broken here?

Upon viewing the changed files 2 files i found are in the PR but not required in my opinion:-

  1. As there are no new dependencies being added nor any change to package.json is there then i believe there should also be no lockfile change.
  2. The lefthook change is probably not needed.

CC:- @AayushSaini101 @Shurtu-gal @Souvikns

neoandmatrix avatar Sep 10 '25 16:09 neoandmatrix

@Shurtu-gal can you take a look at this? thanks : )

AayushSaini101 avatar Oct 19 '25 09:10 AayushSaini101

Also there is conflict with package-lock. Tests should ideally pass upon pushing new commit.

Shurtu-gal avatar Oct 20 '25 10:10 Shurtu-gal

As @Gmin2 has not provided any updates since > 2 months. Proceeding to close the PR.

Shurtu-gal avatar Dec 17 '25 13:12 Shurtu-gal