cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: validate Avro schemas in AsyncAPI files using CLI

Open sarthakNITT opened this issue 5 months ago • 7 comments

Description

fixed #1813 installed "avsc": "^5.7.9", code changes in ./src/commands/validate.ts file

sarthakNITT avatar Aug 02 '25 16:08 sarthakNITT

🦋 Changeset detected

Latest commit: 2252fade3a6271eeff06d21c8de90d7ce6b84c2d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 02 '25 16:08 changeset-bot[bot]

Changeset has been generated for this PR as part of auto-changeset workflow.

Please review the changeset before merging the PR.
---
'@asyncapi/cli': minor
---

feat: validate Avro schemas in AsyncAPI files using CLI

- cafcc85: feat: added avro validation

If you are a maintainer or the author of the PR, you can change the changeset by clicking here

[!TIP] If you don't want auto-changeset to run on this PR, you can add the label skip-changeset to the PR or remove the changeset and change PR title to something other than fix: or feat:.

github-actions[bot] avatar Aug 02 '25 16:08 github-actions[bot]

Hi @Souvikns,

Can you please review the pr.

sarthakNITT avatar Aug 02 '25 16:08 sarthakNITT

@Lazzaretti That file is removed in the latest commit. Made changes and have raised a pr, please review it.

sarthakNITT avatar Nov 04 '25 17:11 sarthakNITT

@sarthakNITT could you please provide a update on this?

Shurtu-gal avatar Dec 17 '25 13:12 Shurtu-gal

/u

Shurtu-gal avatar Dec 17 '25 13:12 Shurtu-gal

@Shurtu-gal Made changes, Please review it.

sarthakNITT avatar Dec 17 '25 21:12 sarthakNITT

Personally I think this issue should be transferred to avro-schema-parser as we are already registering that in validation-service in: https://github.com/asyncapi/cli/blob/9621ea05a71e591b63574acf75f35c566588f3da/src/domains/services/validation.service.ts#L203

Shurtu-gal avatar Dec 18 '25 01:12 Shurtu-gal

@Shurtu-gal Just to confirm I understand correctly: you'd like me to move the Avro schema validation logic (using avsc) directly into the asyncapi/avro-schema-parser package instead of handling it here in the CLI's validation service? If so, I'll close this PR, revert the changes, and open a new PR in the avro-schema-parser repo.

sarthakNITT avatar Dec 18 '25 08:12 sarthakNITT

Exactly but instead of creating a PR there it would be better to first shift the issue ask maintainers there what should be done then start working.

Shurtu-gal avatar Dec 18 '25 08:12 Shurtu-gal

okay, can you please tell me whose the maintainer of that repo?

sarthakNITT avatar Dec 18 '25 08:12 sarthakNITT

Please check CODEOWNERS file there.

Shurtu-gal avatar Dec 18 '25 08:12 Shurtu-gal