feat: validate Avro schemas in AsyncAPI files using CLI
Description
fixed #1813 installed "avsc": "^5.7.9", code changes in ./src/commands/validate.ts file
🦋 Changeset detected
Latest commit: 2252fade3a6271eeff06d21c8de90d7ce6b84c2d
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Changeset has been generated for this PR as part of auto-changeset workflow.
Please review the changeset before merging the PR.
---
'@asyncapi/cli': minor
---
feat: validate Avro schemas in AsyncAPI files using CLI
- cafcc85: feat: added avro validation
If you are a maintainer or the author of the PR, you can change the changeset by clicking here
[!TIP] If you don't want auto-changeset to run on this PR, you can add the label
skip-changesetto the PR or remove the changeset and change PR title to something other thanfix:orfeat:.
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Hi @Souvikns,
Can you please review the pr.
Quality Gate passed
Issues
5 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@Lazzaretti That file is removed in the latest commit. Made changes and have raised a pr, please review it.
@sarthakNITT could you please provide a update on this?
/u
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@Shurtu-gal Made changes, Please review it.
Personally I think this issue should be transferred to avro-schema-parser as we are already registering that in validation-service in: https://github.com/asyncapi/cli/blob/9621ea05a71e591b63574acf75f35c566588f3da/src/domains/services/validation.service.ts#L203
@Shurtu-gal Just to confirm I understand correctly: you'd like me to move the Avro schema validation logic (using avsc) directly into the asyncapi/avro-schema-parser package instead of handling it here in the CLI's validation service? If so, I'll close this PR, revert the changes, and open a new PR in the avro-schema-parser repo.
Exactly but instead of creating a PR there it would be better to first shift the issue ask maintainers there what should be done then start working.
okay, can you please tell me whose the maintainer of that repo?
Please check CODEOWNERS file there.