Proposal: move most of the repos as subpackages to CLI
Why do we need this improvement?
Currently the repos are too granular. We should bring them under a monorepo as subpackages to make stuff easier.
How will this change help?
- Easier maintainence.
- Faster changes
- Overall less overhead.
Subpackages
How could it be implemented/designed?
The following repos are planned for initial:
- server-api: https://github.com/asyncapi/server-api/issues/576
- bundler
- diff
- optimizer
🚧 Breaking changes
Yes
👀 Have you checked for similar open issues?
- [x] I checked and didn't find a similar issue
🏢 Have you read the Contributing Guidelines?
- [x] I have read the Contributing Guidelines
Are you willing to work on this issue?
Yes I am willing to submit a PR!
Need your thoughts on this @Amzani @Souvikns @AayushSaini101. Of course this will be a gradual process, starting with server-api.
cc: @derberg
go ahead - just sync with codeowners from diff, optimizer and bundler.
but I believe it will significantly make work easier, updates easier, and collab easier.
you will only have to update the CONTRIBUTING file to explain ownership. So you know, PR for optimizer, depends on owners of optimizer and they should not be blocked by other maintainers. Modelina have nice Champions setup, just ask @jonaslagoni what he thinks of it after all these years - and if it is a good fit here
When you work on a final PR to move a project inside CLI, I recommend approach that I take in generator, to use https://github.com/newren/git-filter-repo to move the code with all the history. Yes we squash, so history will not end up in master, but we at least get a history of commits on PR level as a reference + after merging the PR all the contributors form history will be reflected in the system. Example: https://github.com/asyncapi/generator/pull/1626
When you work on a final PR to move a project inside CLI, I recommend approach that I take in generator, to use https://github.com/newren/git-filter-repo to move the code with all the history. Yes we squash, so history will not end up in master, but we at least get a history of commits on PR level as a reference + after merging the PR all the contributors form history will be reflected in the system. Example: asyncapi/generator#1626
Sure, I had already started some initial migration of server-api will rewrite that.
yeah in case of server-api I would not be surprised if you actually rewrite it instead of migrating, but yeah, others like optimizer, diff, bundler definitely needs this approach
This issue has been automatically marked as stale because it has not had recent activity :sleeping:
It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.
There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.
Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.
Thank you for your patience :heart: