cli icon indicating copy to clipboard operation
cli copied to clipboard

chore: add Amzani as a code owner

Open Amzani opened this issue 1 year ago • 5 comments

Hey Folks,

I suggest @Amzani as code owner, I want to:

Amzani avatar Mar 11 '24 05:03 Amzani

@Amzani please have a look at https://github.com/asyncapi/cli/issues/668#issuecomment-1613183937

Can you demonstrate that you did some of this and therefore you understand the project you want to maintain?

derberg avatar Mar 11 '24 10:03 derberg

@fmvilas trusted @Amzani to look over a Bounty Issue https://github.com/asyncapi/studio/issues/755#issuecomment-1953820868 he translated design part of CLI into a technical task https://github.com/asyncapi/cli/issues/1214 and he is an active maintainer of Studio https://github.com/asyncapi/studio/pulls?q=is%3Apr+author%3AAmzani

aeworxet avatar Mar 11 '24 10:03 aeworxet

@aeworxet thanks for clarification. Yup I'm aware Samir manages Studio. I also had a sync with @Souvikns that we need to onboard someone so I can quit as maintainers, and Samir's name popped up - which is completely fine.

I just want to be fair and transparent and also consistent with message I share already: https://github.com/asyncapi/cli/issues/668#issuecomment-1613183937

I also proposed a good onboarding task that will be beneficial for the whole project, and great for maintainer onboarding -> https://github.com/asyncapi/cli/issues/781#issuecomment-1988082703

derberg avatar Mar 11 '24 11:03 derberg

@derberg makes sense!

(cc @smoya / @Barbanio - this might be also useful for you as you are designing the Maintainer mentorship program)

Amzani avatar Mar 11 '24 12:03 Amzani

@Amzani I would close it, unless you are fine to update it to reflect https://github.com/asyncapi/cli/issues/1287 but of course once we have all voices there and agreement

derberg avatar Mar 21 '24 07:03 derberg

Sure @derberg I can update this one then and wait for @magicmatatjahu

Amzani avatar Mar 22 '24 07:03 Amzani

I left @magicmatatjahu for now until he is back from holidays, @derberg feel free to merge it or wait.

Amzani avatar Mar 22 '24 07:03 Amzani

/rtm

derberg avatar Apr 24 '24 07:04 derberg

:tada: This PR is included in version 1.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Apr 24 '24 17:04 asyncapi-bot