cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: enable v3 and scala for model generation

Open jonaslagoni opened this issue 1 year ago • 5 comments
trafficstars

Description This PR updates the models command to support AsyncAPI v3 and adds scala support.

It also fixes a bug in the example document by using the Kafka example for v3 as well as using the same file name as for v2 document to stay consistent.

Related issue(s) Fixes https://github.com/asyncapi/modelina/issues/1376

jonaslagoni avatar Feb 12 '24 15:02 jonaslagoni

@derberg it wont be possible to add a test that catches breaking changes in the model generation. The amount of variants you would need to test makes it impossible

jonaslagoni avatar Feb 12 '24 16:02 jonaslagoni

@jonaslagoni not good, but yeah I get your point. So might be that they best would be to block autoupdates 🤔

@Souvikns ?

derberg avatar Feb 27 '24 10:02 derberg

Probably a good idea yea

jonaslagoni avatar Feb 27 '24 10:02 jonaslagoni

Blocking auto-updates makes sense but now we have to manually update most of the libraries, It will prevent the breaking changes but we would miss the minor features.

Souvikns avatar Mar 07 '24 04:03 Souvikns

yeah, it sucks 😞 there is no best approach here 😞 loosing autoupdates sucks

or we complicate too much and nobody cares about output changes 🤔 nobody complains so far that latest modelina was bumped without breaking change

derberg avatar Apr 10 '24 15:04 derberg

Replaced by https://github.com/asyncapi/cli/pull/1376

jonaslagoni avatar Apr 19 '24 14:04 jonaslagoni