cli icon indicating copy to clipboard operation
cli copied to clipboard

Enable new feature from Generator to support templates hosted as private packages

Open derberg opened this issue 1 year ago • 2 comments

Reason/Context

We just released a new feature in Generator -> https://www.asyncapi.com/docs/tools/generator/using-private-template

Description

Would be great to enable new flags in asyncapi generate fromTemplate command that enable user to pass custom registry.url and specific authorization method, like registry.auth or registry.token

@Souvikns I think it is a nice, pretty simple new feature that would be good for onboarding potential new maintainer as it is typical enhancement to existing command - so maintainer candidate learns code from perspective of commands and their tests

derberg avatar Jan 22 '24 09:01 derberg

would like to take this up!

Shiva953 avatar Jan 24 '24 11:01 Shiva953

BTW, should registry.auth and registry.token have a default value, in case none is provided?

Also, should we take the registry.auth as a base64 encoded string value, or take it in the form of "username:password" and then convert it to a base64 encoded value?

Shiva953 avatar Jan 24 '24 12:01 Shiva953

@derberg Is it available to work, I can complete this

AayushSaini101 avatar Apr 21 '24 07:04 AayushSaini101

yeah, I guess so, @Shiva953 in related PR do not respons 2 weeks already

derberg avatar Apr 22 '24 08:04 derberg

yeah, I guess so, @Shiva953 in related PR do not respons 2 weeks already Thanks @derberg

AayushSaini101 avatar Apr 22 '24 09:04 AayushSaini101

@Amzani @derberg Started working on it creating a draft PR

AayushSaini101 avatar May 01 '24 05:05 AayushSaini101

:tada: This issue has been resolved in version 1.13.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar May 14 '24 13:05 asyncapi-bot