bindings icon indicating copy to clipboard operation
bindings copied to clipboard

SNS section not compatible with AsyncAPI 3.0.0

Open mateusz-wlosek-ppro opened this issue 1 year ago • 8 comments

SNS README is not compatible with AsyncAPI 3.0.0 E.g. the section mentions subscribe which is not supported anymore

https://github.com/asyncapi/bindings/blob/master/sns/README.md https://www.asyncapi.com/blog/release-notes-3.0.0

mateusz-wlosek-ppro avatar Jul 15 '24 09:07 mateusz-wlosek-ppro

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

github-actions[bot] avatar Jul 15 '24 09:07 github-actions[bot]

@dpwdec @iancooper please take a look

derberg avatar Aug 20 '24 21:08 derberg

SQS README has the same issue. Any news on that?

jturek-olx avatar Aug 30 '24 05:08 jturek-olx

@jturek-olx @derberg Thanks for pinging me. I'll talk to @dpwdec

iancooper avatar Aug 30 '24 08:08 iancooper

@jturek-olx @derberg I'll draft a new version that uses AsyncAPI V3. However, as we know that V2 is stilled being used widely I think we should keep the V2 bindings available on master. So should we disambiguate them in same way the main project does with a 2.x.x folder and a 3.0.0 folder?

dpwdec avatar Aug 30 '24 13:08 dpwdec

I've raised a PR for SNS: https://github.com/asyncapi/bindings/pull/260/files

dpwdec avatar Aug 30 '24 14:08 dpwdec

I have merged the PR. @jturek-olx @derberg if you still have concerns please comment here and we can look at a fix

iancooper avatar Aug 30 '24 15:08 iancooper

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Dec 29 '24 00:12 github-actions[bot]