asyncapi-react icon indicating copy to clipboard operation
asyncapi-react copied to clipboard

fix: handled the document object being undefined in the parser result.

Open ashmit-coder opened this issue 1 year ago • 6 comments
trafficstars

Description

Changes proposed in this pull request:

  • Handled the document object being undefined.
  • In the changes proposed the code section throws an error when the document object is undefined.

Related issue(s)

Fixes: #874

ashmit-coder avatar Feb 05 '24 12:02 ashmit-coder

Screenshot from 2024-02-05 18-24-41

This is how the erros currently look, if the method is approved , proper css and formating can be added to the errror messages.

ashmit-coder avatar Feb 05 '24 12:02 ashmit-coder

Hey @magicmatatjahu or @derberg I was enhancing the error message but am unable to apply any css to the above text that is being rendered

ashmit-coder avatar Feb 21 '24 08:02 ashmit-coder

Also I would like to know if this is an upstream error or we should handle it here itself and make changes as per the latest state of the parser output

ashmit-coder avatar Feb 21 '24 08:02 ashmit-coder

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 21 '24 09:02 sonarqubecloud[bot]

can you update PR with latest master, and resolve conflicts please 🙏🏼

derberg avatar Jun 13 '24 08:06 derberg

can you update PR with latest master, and resolve conflicts please 🙏🏼

cc @ashmit-coder

ibishal avatar Jul 12 '24 20:07 ibishal

no response in 2 weeks.

closing the PR. @ashmit-coder feel free to open a new PR with resolved conflicts. I'm just closing it for cleanup purposes to not have open and not active PR open forever

derberg avatar Jul 27 '24 18:07 derberg

no response in 2 weeks.

closing the PR. @ashmit-coder feel free to open a new PR with resolved conflicts. I'm just closing it for cleanup purposes to not have open and not active PR open forever

Hey sorry @derberg I was busy with other stuff. I will try to create a new PR during the GSOC period itself.

ashmit-coder avatar Jul 27 '24 18:07 ashmit-coder