asyncapi-react icon indicating copy to clipboard operation
asyncapi-react copied to clipboard

feat: add anchors in headers

Open magicmatatjahu opened this issue 3 years ago • 2 comments

Description

Changes proposed in this pull request:

Add anchors in headers:

image image

Related issue(s) Resolves #599

Gitpod url (you need to login by github accout): https://gitpod.io/#https://github.com/asyncapi/asyncapi-react/pull/619, wait for installing deps and open 3000 port (you should see notification for that).

cc @mcturco @derberg

magicmatatjahu avatar Jul 04 '22 09:07 magicmatatjahu

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 04 '22 09:07 sonarqubecloud[bot]

This is great! I am wondering... would it be useful to add a Copy link function somehow to that link icon? I'm thinking that instead of jumping to the anchor section when you click on it that it will copy the link to visit that section and then provide a popover notice to the user that says something like Link copied. Would that be a useful change or no?

mcturco avatar Jul 05 '22 16:07 mcturco

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Nov 03 '22 00:11 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Mar 11 '23 00:03 github-actions[bot]

Would love to see this added!

unematiii avatar Mar 28 '23 15:03 unematiii

@magicmatatjahu sorry for keeping you waiting with this one. Once you solve conflicts in package-lock files, I approve and we can release it

derberg avatar Apr 03 '23 16:04 derberg

@magicmatatjahu do you plan to work on this?

derberg avatar Apr 24 '23 15:04 derberg

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Aug 23 '23 00:08 github-actions[bot]

next will soon be deleted. It is already merged into master and 1.0 is now available.

no more long living release branches!

sorry for any trouble with your PR 😞 but we really had to finally release this v1 and get rid of release branch

I close this PR as I think it is better for you to recreate a new fresh PR targeting master. Feel free to drop a comment if you disagree and I will reopen ☮️

derberg avatar Sep 28 '23 14:09 derberg