asyncapi-react icon indicating copy to clipboard operation
asyncapi-react copied to clipboard

fix: #907 sidebar broken in playground

Open surajTade opened this issue 1 year ago • 12 comments

Description

Changes proposed in this pull request:

  • Corrected the CSS that was controlling the width of the sidebar

Related issue(s)

Fixes #907, #908

surajTade avatar Oct 05 '24 16:10 surajTade

@surajTade can you share a video of your fix?

AceTheCreator avatar Oct 05 '24 17:10 AceTheCreator

@surajTade can you share a video of your fix?

https://github.com/user-attachments/assets/af6e4c5c-df34-432e-8a01-906eae9bf546

surajTade avatar Oct 05 '24 17:10 surajTade

@surajTade i don't think you're doing the correct thing here 👀

I tired that fix on different screen sizes and it seems to be working fine, can you please elaborate on what could be wrong in this?

surajTade avatar Oct 05 '24 17:10 surajTade

This is what i get when i test your implementation here: https://github.com/user-attachments/assets/27c15026-6f77-42d5-96b3-5abda7984c28

AceTheCreator avatar Oct 05 '24 22:10 AceTheCreator

This is what i get when i test your implementation here: https://github.com/user-attachments/assets/27c15026-6f77-42d5-96b3-5abda7984c28

I see, I'm not sure why I'm not facing this issue:

https://github.com/user-attachments/assets/96729d2f-78f9-4a9c-a275-d842363ea1b4

surajTade avatar Oct 06 '24 04:10 surajTade

@surajTade your implementation should result to this https://github-production-user-asset-6210df.s3.amazonaws.com/40604284/373625058-e20adf82-4105-40f3-bd7d-1086a18abbfb.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20241007%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241007T123358Z&X-Amz-Expires=300&X-Amz-Signature=555c8aec1a53e5824216ea1fefe8ffde1af923eb47c070501f41e913ae872eea&X-Amz-SignedHeaders=host

AceTheCreator avatar Oct 07 '24 12:10 AceTheCreator

@surajTade here's a draft PR that fixes this https://github.com/asyncapi/asyncapi-react/pull/1072/files. You can copy the fix from there :)

AceTheCreator avatar Oct 07 '24 12:10 AceTheCreator

image This is what happens when I apply your fix!

surajTade avatar Oct 07 '24 13:10 surajTade

image This is what happens when I apply your fix!

That's strange. Can i see your implementation? maybe update this PR with suggested changes

AceTheCreator avatar Oct 07 '24 18:10 AceTheCreator

@surajTade, removed the changes you made to the layout file. Kindly test it :)

AceTheCreator avatar Oct 14 '24 13:10 AceTheCreator

@surajTade any update?

AceTheCreator avatar Oct 17 '24 11:10 AceTheCreator

/rtm

AceTheCreator avatar Nov 04 '24 09:11 AceTheCreator

:tada: This PR is included in version 2.4.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Nov 04 '24 09:11 asyncapi-bot