:bug: bug : navigation tab is not working properly
Description
- Navigation tab between schema and configuration is not working as expected.
Expected Result
- It should navigate properly between the schema tab and configuration tab.
Screencast from 2024-05-30 17-23-42.webm
Actual Result
Screencast from 2024-05-30 17-28-34.webm
Steps to Reproduce
- Go to the AsyncAPI website homepage.
- Click on the configuration tab.
- Click on the schema tab.
- Try to navigate back to the configuration tab.
Troubleshooting
- I found there is issue in
tabIndex. Basically in one of if statement we are checkingtabIndexbuttabIndexis value can equal to zero andschematab tabIndex is zero so when navigating back to schema tab from configuration tab. If statement is not working and hence navigation is not working.
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
I would love to work on this issue : )
@aialok please go ahead and open a PR
Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?
Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?
@AnshulKahar2729 do you mean contributors guideline?
Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?
@AnshulKahar2729 do you mean contributors guideline?
Yes
Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?
@AnshulKahar2729 do you mean contributors guideline?
Yes
These are the ones I recommend.
- https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md
- https://github.com/asyncapi/community/blob/master/git-workflow.md
Let me know if you need any help 🙏🏾
@AceTheCreator This issue still persists right, can I pick it up?
@AceTheCreator This issue still persists right, can I pick it up?
Someone opened a PR for it already, sadly. Feel free to pick other existing issues.
:tada: This issue has been resolved in version 2.2.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket: