asyncapi-react icon indicating copy to clipboard operation
asyncapi-react copied to clipboard

:bug: bug : navigation tab is not working properly

Open aialok opened this issue 1 year ago • 3 comments

Description

  • Navigation tab between schema and configuration is not working as expected.

Expected Result

  • It should navigate properly between the schema tab and configuration tab.

Screencast from 2024-05-30 17-23-42.webm

Actual Result

Screencast from 2024-05-30 17-28-34.webm

Steps to Reproduce

  1. Go to the AsyncAPI website homepage.
  2. Click on the configuration tab.
  3. Click on the schema tab.
  4. Try to navigate back to the configuration tab.

Troubleshooting

  • I found there is issue in tabIndex. Basically in one of if statement we are checking tabIndex but tabIndex is value can equal to zero and schema tab tabIndex is zero so when navigating back to schema tab from configuration tab. If statement is not working and hence navigation is not working.

aialok avatar May 30 '24 12:05 aialok

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

github-actions[bot] avatar May 30 '24 12:05 github-actions[bot]

I would love to work on this issue : )

aialok avatar May 30 '24 12:05 aialok

@aialok please go ahead and open a PR

derberg avatar Jun 20 '24 11:06 derberg

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

AnshulKahar2729 avatar Aug 10 '24 12:08 AnshulKahar2729

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

AceTheCreator avatar Aug 12 '24 15:08 AceTheCreator

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

Yes

AnshulKahar2729 avatar Aug 16 '24 20:08 AnshulKahar2729

Hey @derberg, I am about to raise a PR for this issue but before that I want to read the guidelines to raise PR, can you help me where can I find out those guidelines?

@AnshulKahar2729 do you mean contributors guideline?

Yes

These are the ones I recommend.

  • https://github.com/asyncapi/asyncapi-react/blob/master/CONTRIBUTING.md
  • https://github.com/asyncapi/community/blob/master/git-workflow.md

AceTheCreator avatar Aug 22 '24 13:08 AceTheCreator

Let me know if you need any help 🙏🏾

AceTheCreator avatar Aug 22 '24 13:08 AceTheCreator

@AceTheCreator This issue still persists right, can I pick it up?

ajaykumar-br avatar Oct 04 '24 18:10 ajaykumar-br

@AceTheCreator This issue still persists right, can I pick it up?

Someone opened a PR for it already, sadly. Feel free to pick other existing issues.

AceTheCreator avatar Oct 07 '24 18:10 AceTheCreator

:tada: This issue has been resolved in version 2.2.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Oct 07 '24 18:10 asyncapi-bot