futures-timer icon indicating copy to clipboard operation
futures-timer copied to clipboard

Published 20 hours ago • verified publisher icon async-rs

Add wasm-bindgen feature to README/docs

Open qdot opened this issue 4 years ago • 3 comments

Just found out there's a wasm-bindgen feature via the PR then reading the Cargo.toml. Would be nice to have this in the README.

qdot avatar Jan 25 '21 04:01 qdot

Wouldn't it be better to automatically turn these dependencies on on wasm? AFAICT the library can't work on wasm without them. It would save users from having to fiddle with feature flags.

najamelan avatar May 31 '21 16:05 najamelan

Sure, that'd work too.

qdot avatar May 31 '21 17:05 qdot

Wouldn't it be better to automatically turn these dependencies on on wasm? AFAICT the library can't work on wasm without them. It would save users from having to fiddle with feature flags.

I agree that it would be better to have it enabled based on the target, especially since it doesnt fail to build on non-wasm32 targets, it makes it hard to debug the time not implemented on this platform panic message when Instant or SystemTime is used from std due to Instant being used by the native module.

dariusc93 avatar May 02 '24 15:05 dariusc93