async-std icon indicating copy to clipboard operation
async-std copied to clipboard

💄 Make TODO chapters in Book as unclickable

Open s373r opened this issue 4 years ago • 4 comments

To prevent opening empty pages this PR makes links unclickable from visual and interaction perspectives.

Please check the following preview images:

Before After
before after

Inspired by https://github.com/rust-lang/async-book

s373r avatar Oct 29 '21 10:10 s373r

It seems this might be causing CI to fail; if we could fix that we should be good to merge!

yoshuawuyts avatar Nov 02 '21 12:11 yoshuawuyts

Hello all!

I've made a little investigation why we got a fail as a result of this CI job (and more interested for me why I couldn't get that locally)

Results

Some thoughts

  • Since CI is an internal thing I cannot update the version from 0.3.7 to 0.4.X -- also, I don't know the real reasons why the version is pinned currently (it may be some needed workaround 🤔 )

Possible next steps

  1. The version can be updated if we have no strong reason not to do so

OR

  1. This PR can wait for version updating and I'll update it later if needed

@Fishrock123 & @yoshuawuyts please see ^^^ if something seems unclear feel free to ping me

Anyway I will wait for feedback :)

s373r avatar Nov 03 '21 18:11 s373r

Added 40741ff that should fix CI build error

s373r avatar Nov 11 '21 13:11 s373r

We still want to pin a version, we should just update the pin from 0.3 to 0.4.

(Also, there's a typo: "mdbookk" should be "mdbook".)

joshtriplett avatar Jun 02 '22 18:06 joshtriplett