async-std icon indicating copy to clipboard operation
async-std copied to clipboard

Consider making waker_set its own crate

Open tmccombs opened this issue 4 years ago • 5 comments

I think the waker_set implementation is useful in it's own right. At the very least futures-util has something very similar and could probably benefit from sharing the waker_set implementation between the crates. It also may be useful in implementing other synchronization abstractions or combinators that need to keep track of a list of tasks to notify.

tmccombs avatar Nov 16 '19 07:11 tmccombs

@tmccombs agree, that'd be great. I think @stjepang and I talked about it offline a while back, but we would like to also be able to share AtomicWaker alongside WakerSet.

yoshuawuyts avatar Nov 19 '19 22:11 yoshuawuyts

Maybe we could use the async-utils name for this?

yoshuawuyts avatar Nov 19 '19 22:11 yoshuawuyts

I wrote a standalone crate similar to WakerSet: https://github.com/tmccombs/waitlist. In fact it started out as just a separate crate for WakerSet, but then I had some ideas I wanted to try out it ended up rather different than the original WakerSet.

tmccombs avatar Apr 27 '20 05:04 tmccombs

There is https://github.com/stjepang/piper/blob/master/src/event.rs now, which is very similar, but not yet exposed from the crate itself.

dignifiedquire avatar Apr 27 '20 09:04 dignifiedquire

What are the plans for the WakerSet? In this issue #728 it was stated that WakerSet was meant to be put in the async-utils crate. However, async-utils seems to be not active.

Seen the comment from @dignifiedquire , is the event-listener from @stjepang meant to be a replacement for the WakerSet?

Mallets avatar Dec 14 '20 08:12 Mallets