async-graphql icon indicating copy to clipboard operation
async-graphql copied to clipboard
verified publisher icon async-graphql

fix: use the tracing crate with its original package name.

Open mythrnr opened this issue 6 months ago • 3 comments

Pull Request Overview

This pull request updates the use of the tracing crate to align with recent changes in its upstream release, removing the use of the tracinglib alias.

Changes

  • Updates Cargo.toml to refer to the tracing crate directly, instead of using the tracinglib alias.
  • Adjusts the "tracing" feature declaration to use dep:tracing for clarity and alignment with Cargo best practices.
  • Updates import paths in relevant modules (dataloader, extensions::tracing) to use the standard tracing crate directly.

Reasons for Changes

  • The update accommodates breaking changes in the tracing-attributes crate, which made the alias approach no longer viable.

mythrnr avatar Jun 19 '25 16:06 mythrnr

Any progress on merging this?

bbigras avatar Sep 18 '25 20:09 bbigras

any progress on this? I tested this fix on my codebase as well, and seems like it works.

0xsiddharthks avatar Dec 01 '25 19:12 0xsiddharthks

I'm also waiting for this PR to be reviewed. @sunli829 , what do you think about this PR?

mythrnr avatar Dec 02 '25 03:12 mythrnr