aws icon indicating copy to clipboard operation
aws copied to clipboard

The BC Checks CI setup reports weird issues

Open stof opened this issue 3 years ago • 2 comments

The BC checks for async-aws/illluminate-queue are currently failing, saying that some Illuminate\Queue methods are being removed. Those are not BC break in the async-aws package, but in Laravel. So it looks like something is weird in the configuration of the CI.

stof avatar Jan 25 '22 15:01 stof

hmm.. Actually, AsyncAwsSqsQueue extends Illuminate\Queue\Queue and AsyncAwsSqsJob extends Illuminate\Queue\Jobs\Job

When allowing illuminate/queue": "... || ^8.0 in our dependencies, we broke the BC of async-aws.

I'm not sure how to fix this one. Any suggestion?

jderusse avatar Jan 26 '22 14:01 jderusse

oh, I missed that.

I would say, make it a new semver major version of this package then (that is, 0.2.0).

stof avatar Jan 26 '22 15:01 stof

I think this is getting fixed today, so can be closed later today, assuming the last change to make works.

GrahamCampbell avatar Jun 13 '23 10:06 GrahamCampbell

Yep, fixed. This issue can be closed @jderusse.

GrahamCampbell avatar Jun 13 '23 10:06 GrahamCampbell