forte icon indicating copy to clipboard operation
forte copied to clipboard

Create basic (lower) level interface for attributes (for new feature #920)

Open J007X opened this issue 2 years ago • 1 comments

This PR fixes https://github.com/asyml/forte/issues/920.

Description of changes

(In this phase-1,) Interface methods are added to the "Data_Store" level to provide basic services that expand the previous service/methods by allowing batch-like, range selection of attributes from one or more entries (such as with one or more tid, or type-specific)

Possible influences of this PR.

This provides a new attribute based interface without the cost of packing and unpacking into classes for quicker attribute access (such as for entries). Do we need to restrict access in some ways?

Test Conducted

Corresponding unit tests are created.

J007X avatar Feb 14 '23 12:02 J007X

Codecov Report

Merging #921 (36a7c56) into master (35c1ced) will increase coverage by 0.01%. The diff coverage is 84.46%.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   81.06%   81.07%   +0.01%     
==========================================
  Files         256      256              
  Lines       19858    19961     +103     
==========================================
+ Hits        16097    16184      +87     
- Misses       3761     3777      +16     
Impacted Files Coverage Δ
forte/data/data_store.py 91.59% <76.47%> (-1.72%) :arrow_down:
tests/forte/data/data_store_test.py 95.96% <100.00%> (+0.38%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Mar 22 '23 13:03 codecov[bot]