forte icon indicating copy to clipboard operation
forte copied to clipboard

Incorporate remote clinical pipeline and stave

Open Piyush13y opened this issue 3 years ago • 5 comments

This PR fixes #745.

Description of changes

We provide a remote service pipeline that handles interaction between the chatbot and the elastic search indexer, to get the results visualized through stave on the UI. We also create 2 stave projects in the script, one for annotation viewing and the other to act as the search engine/chat bot.

Piyush13y avatar May 20 '22 02:05 Piyush13y

Codecov Report

Merging #793 (c9aa59f) into master (8e03abe) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files         254      254           
  Lines       19364    19364           
=======================================
  Hits        15637    15637           
  Misses       3727     3727           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e03abe...c9aa59f. Read the comment docs.

codecov[bot] avatar May 20 '22 02:05 codecov[bot]

@hunterhector I am assuming we are planning to abandon this PR, now that we have a PR in ForteHealth to add this example there? Or do we want to push it here too?

Piyush13y avatar Jul 16 '22 01:07 Piyush13y

@hunterhector I am assuming we are planning to abandon this PR, now that we have a PR in ForteHealth to add this example there? Or do we want to push it here too?

If everything is moved there we should remove one of them (probably this one). Otherwise, we will have to maintain multiple versions

hunterhector avatar Jul 16 '22 01:07 hunterhector

@hunterhector I am assuming we are planning to abandon this PR, now that we have a PR in ForteHealth to add this example there? Or do we want to push it here too?

If everything is moved there we should remove one of them (probably this one). Otherwise, we will have to maintain multiple versions

We will then have to remove the whole example here then? Because it won't work the old way now that Stave uses RemoteProcessors. As in, removing the clinical_processing_pipeline folder itself from forte/examples; or we will have to strip some functionalities and just keep a non stave interaction example, but that again would be an effective copy of our MIMIC3 example in ForteHealth? https://github.com/asyml/ForteHealth/blob/master/examples/mimic_iii/medical_pipeline.py

Piyush13y avatar Jul 16 '22 01:07 Piyush13y

@hunterhector I am assuming we are planning to abandon this PR, now that we have a PR in ForteHealth to add this example there? Or do we want to push it here too?

If everything is moved there we should remove one of them (probably this one). Otherwise, we will have to maintain multiple versions

We will then have to remove the whole example here then? Because it won't work the old way now that Stave uses RemoteProcessors. As in, removing the clinical_processing_pipeline folder itself from forte/examples; or we will have to strip some functionalities and just keep a non stave interaction example, but that again would be an effective copy of our MIMIC3 example in ForteHealth? https://github.com/asyml/ForteHealth/blob/master/examples/mimic_iii/medical_pipeline.py

I think we can just remove the whole thing since we have a complete example in the other repo

hunterhector avatar Jul 16 '22 01:07 hunterhector

close since most of the code is moved out and this pr is inactive

hunterhector avatar Dec 22 '22 17:12 hunterhector