forte icon indicating copy to clipboard operation
forte copied to clipboard

Support cache for `_is_annotation`

Open wanglec opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. We want to add the cache functionality for the function _is_annotation. It should remember whether the entry is annotated-like once it has been checked.

Depends on

  • List issues that this one depends on.

Describe the solution you'd like We may use a lru decorator to cache the return value of this function.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context

  • This is part of the data efficiency project
  • This PR should be made to the master branch.
  • After the data tuple class is finished, we may switch to a new branch for integration.

wanglec avatar Apr 18 '22 08:04 wanglec

@mylibrar double check to see if this is addressed, or assign a milestone

hunterhector avatar May 24 '22 16:05 hunterhector

addressed in another pr.

hunterhector avatar Dec 22 '22 18:12 hunterhector