forte icon indicating copy to clipboard operation
forte copied to clipboard

Check Correctness of Copying Link and Group during Augmentation

Open Pushkar-Bhuse opened this issue 3 years ago • 0 comments

Describe the bug During augmentation, the newly created data pack copies the links and groups of the original data pack. We suspect that the user defined features which may be a part of the group may not be getting copied.

To Reproduce Steps to reproduce the behavior: This can be check in the tests of the BaseOpProcessor:

  1. https://github.com/Pushkar-Bhuse/forte/blob/131f80fde277d9471332db670f9dd6b6ff64710d/tests/forte/processors/data_augment/algorithms/base_data_augmentation_op_test.py#L203
  2. https://github.com/Pushkar-Bhuse/forte/blob/131f80fde277d9471332db670f9dd6b6ff64710d/tests/forte/processors/data_augment/algorithms/base_data_augmentation_op_test.py#L453

However, in these tests, the copying of user defined attributes of links and groups is not tested. This is the behavior that needs to be tested. If the above mentioned concern is true, then there need to be changes made in how links and groups are copied here: https://github.com/asyml/forte/blob/92fe7280f7faddbf7b67a3bbc174f316caf24d62/forte/processors/data_augment/algorithms/base_data_augmentation_op.py#L125

Pushkar-Bhuse avatar Mar 30 '22 23:03 Pushkar-Bhuse