Andrew Svetlov

Sorry, I don't follow how to use the helper. Full test coverage is required also.

Well, idea is good but it should be proved by test suite.

Tests still are red :(

Sorry, wrote comments two days ago but forgot to press "Submit" button.

The code is written good and well tested, but let's discuss the usage design. Now the API is: ``` session = aiohttp.ClientSession() auth = aiohttp.DigestAuth('user', 'password', client) resp = await...

I like the idea but have a feeling that we need to use slightly different and not existing yet API for it.

@sonicblind thanks for the comment. The PR doesn't go to merge but I'd like to keep it open as a reference for eventual new implementation built from scratch.

aiohttp doesn't use weak references to break cycles between moving parts. In practice, it means that the memory is released not immediately but at the next call of the garbage...

OK. BTW, for checking on different Python versions I use https://github.com/pyenv/pyenv ``` pyenv install 3.9.0 pyenv virtualenv 3.9.0 aiohttp-3.9.0 pyenv local aiohttp-3.9.0 ``` Works like a charm. P.S. Need to...

Oooh. Thanks. At least I have comprehensive instruction for "how to reproduce".