Andrew Svetlov

Results 374 comments of Andrew Svetlov

The same is true if user doesn't call `await writer.close()` but just `writer.close()`. In any case the stream will be closed safely. I don't propose raising any exception from `await...

Otherwise we should suggest `await sleep(0)` after any `writer.close()` call which smells bad.

No, I don't propose converting `.close()` to coroutine. What I want to do is leaving it as regular function which returns a future object. The future will become ready on...

+1, LGTM Do we need tests? I pretty sure we do.

+1 for keeping `.run()` only for main thread. Also I would like to have `.interrupt()`. @1st1 has described the need very well I believe. Yep, `forever` was ambiguous name but...

The latest patch is really great. Using regular coroutine for client code and something like `contextlib.contextmanager` for server ones fits pretty clean into my mind.

I think first option (`{push,peek,pop}_coroutine_runner`) is better than allowing to yield non-futures from async methods. But anyway I would to stress that [async PEP](https://www.python.org/dev/peps/pep-3156/) mention `Task` class many times (but...

Fixes #404

`_FATAL_ERROR_IGNORE` is a tuple of exceptions which doesn't generate noisy `loop.call_exception_handler()` if connection cannot be established (see https://github.com/python/asyncio/blob/master/asyncio/selector_events.py#L633) for usage example. `ssl.CertificateError` goes to this category -- it could be...

See also aiofiles library: https://github.com/Tinche/aiofiles