dragscroll icon indicating copy to clipboard operation
dragscroll copied to clipboard

Published 20 hours ago • verified publisher icon asvd

Fix intuitive propagation behavior

Open zach-capalbo opened this issue 5 years ago • 4 comments

  • Add small threshold to begin dragging
  • Don't propagate clicks to scrolled element after movement has reached threshold
    • Useful if you are scrolling something with lots of links or buttons in it
  • Don't propagate mousedown events
    • Useful if you have .dragscrolls embedded in other .dragscrolls

These changes break current behavior, and add a few more bytes, but it makes the behavior a lot more intuitive to me. Creating the pull request in case it seems more intuitive to anyone else.

zach-capalbo avatar Jul 18 '19 15:07 zach-capalbo

this works perfectly for me. I suggest to merge this.

Metis77 avatar Aug 07 '19 17:08 Metis77

This worked really well as a fix on a sliding navigation bar, where navigation clicks were being incorrectly detected as drags in some cases.

laurenwithcats avatar May 01 '20 21:05 laurenwithcats

+1 for the works really well! SHOULD MERGE!

jonasgoddeeris avatar Jan 31 '22 22:01 jonasgoddeeris

Worked

xandeadx avatar Dec 08 '23 20:12 xandeadx