berkeleytime
berkeleytime copied to clipboard
Add data query param for login flow
/api/login will now accept a query param 'data' that will be passed back after authentication
Frontend build seems to be breaking here:
Failed to compile.
/frontend/src/components/Catalog/FilterResults.tsx
TypeScript error in /frontend/src/components/Catalog/FilterResults.tsx(85,15):
No overload matches this call.
Overload 1 of 2, '(props: FixedSizeListProps<{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }> | Readonly<...>): FixedSizeList<...>', gave the following error.
Type '{ courses: CourseOverviewFragment[]; sortBy: CourseSortAttribute; selectCourse: ((course: CourseOverviewFragment) => void) | undefined; selectedCourse: CourseReference | null; }' is not assignable to type '{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }'.
Types of property 'selectCourse' are incompatible.
Type '((course: CourseOverviewFragment) => void) | undefined' is not assignable to type '(course: CourseOverviewFragment) => void'.
Type 'undefined' is not assignable to type '(course: CourseOverviewFragment) => void'.
Overload 2 of 2, '(props: FixedSizeListProps<{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }>, context: any): FixedSizeList<...>', gave the following error.
Type '{ courses: CourseOverviewFragment[]; sortBy: CourseSortAttribute; selectCourse: ((course: CourseOverviewFragment) => void) | undefined; selectedCourse: CourseReference | null; }' is not assignable to type '{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }'. TS2769
83 | height={height}
84 | width={width}
> 85 | itemData={courseCardProps}
| ^
86 | itemCount={sortedCourses.length}
87 | itemSize={110}
88 | itemKey={(index) => sortedCourses[index].id}
@vihanb do you know anything about this?
@LEON-MING this should be fixed in master; I believe the fix is changing the line to courseCardProps as any (weird Typescript stuff)
I'm closing this as stale. The backend has been rewritten in Node since 2023.