berkeleytime icon indicating copy to clipboard operation
berkeleytime copied to clipboard

Add data query param for login flow

Open leon-ming opened this issue 4 years ago • 2 comments

/api/login will now accept a query param 'data' that will be passed back after authentication

leon-ming avatar Apr 27 '21 05:04 leon-ming

Frontend build seems to be breaking here:

Failed to compile.
/frontend/src/components/Catalog/FilterResults.tsx
TypeScript error in /frontend/src/components/Catalog/FilterResults.tsx(85,15):
No overload matches this call.
  Overload 1 of 2, '(props: FixedSizeListProps<{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }> | Readonly<...>): FixedSizeList<...>', gave the following error.
    Type '{ courses: CourseOverviewFragment[]; sortBy: CourseSortAttribute; selectCourse: ((course: CourseOverviewFragment) => void) | undefined; selectedCourse: CourseReference | null; }' is not assignable to type '{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }'.
      Types of property 'selectCourse' are incompatible.
        Type '((course: CourseOverviewFragment) => void) | undefined' is not assignable to type '(course: CourseOverviewFragment) => void'.
          Type 'undefined' is not assignable to type '(course: CourseOverviewFragment) => void'.
  Overload 2 of 2, '(props: FixedSizeListProps<{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }>, context: any): FixedSizeList<...>', gave the following error.
    Type '{ courses: CourseOverviewFragment[]; sortBy: CourseSortAttribute; selectCourse: ((course: CourseOverviewFragment) => void) | undefined; selectedCourse: CourseReference | null; }' is not assignable to type '{ courses: CourseOverviewFragment[]; selectCourse: (course: CourseOverviewFragment) => void; sortBy: CourseSortAttribute; selectedCourse: CourseReference | null; }'.  TS2769
    83 |               height={height}
    84 |               width={width}
  > 85 |               itemData={courseCardProps}
       |               ^
    86 |               itemCount={sortedCourses.length}
    87 |               itemSize={110}
    88 |               itemKey={(index) => sortedCourses[index].id}

@vihanb do you know anything about this?

leon-ming avatar May 02 '21 22:05 leon-ming

@LEON-MING this should be fixed in master; I believe the fix is changing the line to courseCardProps as any (weird Typescript stuff)

g-luo avatar May 13 '21 21:05 g-luo

I'm closing this as stale. The backend has been rewritten in Node since 2023.

mathhulk avatar Jul 26 '24 01:07 mathhulk