pacmod3 icon indicating copy to clipboard operation
pacmod3 copied to clipboard

Published 20 hours ago • verified publisher icon astuff

Firmware version included in message or new topic

Open icolwell-as opened this issue 5 years ago • 3 comments

I think it would be very helpful to have the PACMod firmware version published to an existing topic or to some new topic. This way a recorded rosbag always has PACMod firmware version already included.

icolwell-as avatar May 31 '19 03:05 icolwell-as

This first requires a change to the DBC (and firmware) to transmit the version. This is underway in astuff/pacmod_dbc#10. Once that issue is implemented, I'll follow up with relevant changes to the driver.

JWhitleyWork avatar Jun 13 '19 19:06 JWhitleyWork

@icolwell-as - This is now available in the DBC and will be published by newer versions of the firmware (see https://github.com/astuff/pacmod_dbc/commit/f785a2c9171563aba956dcfe6397b305482cfdfb). Would you mind implementing it in the driver?

JWhitleyWork avatar Oct 29 '19 20:10 JWhitleyWork

Sounds good! I might not get to it for a while, but I'm interested to learn more about this driver in the process.

icolwell-as avatar Oct 29 '19 21:10 icolwell-as