sanctuary icon indicating copy to clipboard operation
sanctuary copied to clipboard

PEP8 Automatic PR checks (Code Linting)

Open amaank404 opened this issue 4 years ago • 6 comments

My goals:

  • PEP8 action to ensure good and readable code when submitting a PR or pushing changes
  • Format the already present code before implementing the action itself.

Other goals (I will be rasing issues for them after this):

  • Add a CONTRIBUTING.md (A github file which instructs users how to work if they want to contribute)

amaank404 avatar Dec 16 '20 05:12 amaank404

Thank you for creating this issue @xcodz-dot.

gridhead avatar Dec 18 '20 03:12 gridhead

please assign this to me.

amaank404 avatar Jan 15 '21 06:01 amaank404

@[email protected] [email protected] it would be helpful if you could assign this issue.

Thanks.

On Fri, Jan 15, 2021 at 11:37 AM xcodz-dot [email protected] wrote:

please assign this to me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/astrosonic/sanctuary/issues/73#issuecomment-760674007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL2O2QUP2XZSX5NXGXG6B7LSZ7LTHANCNFSM4U5OE6IA .

gridhead avatar Jan 15 '21 06:01 gridhead

Hello @shivangswain, please look at this #74, so i can apply further changes for code linting action

amaank404 avatar Jan 22 '21 08:01 amaank404

Hi @xcodz-dot,

I know it has been a long while since we last attended your issues/PRs and I understand that it can be disheartening to be in such a situation. We would definitely get back to working on this at a later date, whenever we would find some time out of the tasks we are usually engaged in. Thanks for contributing. :)

gridhead avatar May 31 '21 03:05 gridhead

:)

amaank404 avatar May 31 '21 04:05 amaank404