sanctuary icon indicating copy to clipboard operation
sanctuary copied to clipboard

Published 20 hours ago • verified publisher icon astrosonic

created package for websockets server in an executable binary

Open sachin2912 opened this issue 4 years ago • 6 comments

resolves #57 @t0xic0der

sachin2912 avatar Sep 30 '20 18:09 sachin2912

i had a question to your work, What platforms does your pull request add?

amaank404 avatar Oct 02 '20 09:10 amaank404

i also recommend you to remove the build folder (It is unnecessary).

amaank404 avatar Oct 02 '20 09:10 amaank404

keep it up 👍

amaank404 avatar Oct 02 '20 09:10 amaank404

executable binary file created is for Linux (as sanctuary is not tested on windows yet) , specifically Ubuntu 20.04 LTS and python 3.8.2 . build folder can be useful for debugging , still if maintainer want i can remove build folder.

sachin2912 avatar Oct 03 '20 12:10 sachin2912

i had a question to your work, What platforms does your pull request add?

Sanctuary works only in GNU/Linux based operating systems. I thought that was evident with the screenshots attached in the documentation.

i also recommend you to remove the build folder (It is unnecessary).

I believe we should leave that for the maintainer to decide about the stuff which is necessary and about those which aren't.

gridhead avatar Oct 05 '20 02:10 gridhead

@sachin2912 Thanks for your contribution to the repository. Allow us some time to review your pull request.

gridhead avatar Oct 05 '20 02:10 gridhead