specutils icon indicating copy to clipboard operation
specutils copied to clipboard

Published 20 hours ago • verified publisher icon astropy

First Pass WCS extract region bound fix

Open duytnguyendtn opened this issue 3 years ago • 3 comments

Addresses #869 @PatrickOgle identified a bug in extract_regions where the WCS wavelength reference value (CRVAL0) wasn't being updated to the new bounds of the extracted region. Implemented Patrick's solution in this PR. Still need to figure out what the appropriate solution would be for GWCS though...

duytnguyendtn avatar Oct 13 '21 22:10 duytnguyendtn

Poked around in SpectralGWCS, other than adjusting the size of the bounding box, I'm not sure if I can see a place where an equivalent slice would be appropriate, or even possible. I'm not sure, and the ticket #869 doesn't suggest, this problem exists with SpectralGWCS defined WCS's, so I'm going to mark this ready for review and request someone who knows better than I do clarify!

duytnguyendtn avatar Oct 15 '21 21:10 duytnguyendtn

@duytnguyendtn I am not familiar with GWCS and have not tried to use spectral_slab on it. We can either:

  1. Test this PR on a Spectrum1D with GWCS
  2. ...OR file a ticket for GWCS later if there is problem ...your choice.

PatrickOgle avatar Oct 18 '21 13:10 PatrickOgle

As discussed, if we want to revisit, the solution should adhere to APE 14 high-level API if possible. That way, it would naturally work for both FITS WCS and GWCS.

pllim avatar Dec 23 '22 16:12 pllim