specreduce icon indicating copy to clipboard operation
specreduce copied to clipboard

Compatibility with specutils 2.0

Open pllim opened this issue 10 months ago • 1 comments

specutils 2.0rc1 is out. It is imperative that we leverage the synergy of this package with that package.

From https://github.com/astropy/specutils/discussions/1221:

A quick run over at https://github.com/astropy/astropy-integration-testing/ failed for specreduce. Do the tracebacks look familiar to you?

https://github.com/astropy/astropy-integration-testing/actions/runs/13929757409/job/38983646191

Here is a native specreduce run, also failed:

https://github.com/astropy/specreduce/actions/runs/13892729677/job/38983700486

@rosteen said:

Yes, basically it looks like specreduce will need to add spectral_axis_index=disp_axis in the Spectrum creation call in _get_data_from_image (and maybe one or two other places, that's just the first one I looked at). The test images are 10x10, so specutils can't automatically determine which axis is the spectral axis, since both flux axes have the same size as the spectral axis array that's input (specutils no longer assumes that the last axis corresponds to the spectral axis).

pllim avatar Mar 18 '25 18:03 pllim

I can probably take a stab at this. See https://github.com/astropy/specreduce/pull/260

pllim avatar Mar 18 '25 19:03 pllim