astroquery
astroquery copied to clipboard
astropy
Parametrize remote fixtures
Hello @volodymyrss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
astroquery/utils/testing_parametrization.py:
Line 140:9: E265 block comment should start with '# '
Comment last updated at 2022-03-26 08:59:26 UTC
@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in main from #2250, and if not then close it? Thanks!
@volodymyrss - Is this still relevant? If yes, could you remove the commits that are already in
mainfrom #2250, and if not then close it? Thanks!
It's still relevant, it's meant to relocate the fixtures for this test parametrization (creating remote data automatically) to common location, not specific to heasarc. I had no time to finish it yet, sorry. It might take some month before I get to it again. Is it ok to keep it as draft for a while? I could also close and recreate it later. I made it all in one commit for now.
Is it ok to keep it as draft for a while?
That sounds all good, as you may have seen we don't put a time limit on PRs in this repo. However, I removed the milestone so it won't pop up at release time.