astropy-workshop icon indicating copy to clipboard operation
astropy-workshop copied to clipboard

Bugfixes for data downloads in specutils analysis notebooks

Open bmorris3 opened this issue 1 year ago • 2 comments

CI is currently failing on both specutils analysis notebooks because a data file is assumed to exist when it does not. I've added lines to ensure that the necessary file download happens no matter when a given notebook runs.

bmorris3 avatar Jul 22 '24 19:07 bmorris3

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This PR will need to bump the pin on specutils after its next release (with https://github.com/astropy/specutils/pull/1156).

bmorris3 avatar Jul 23 '24 16:07 bmorris3

The specutils-related notebooks now pass the tests. The remaining failure is due to breaking changes in the photutils v2.0 release, which @larrybradley will be fixing shortly.

bmorris3 avatar Oct 22 '24 15:10 bmorris3