astropy-tutorials icon indicating copy to clipboard operation
astropy-tutorials copied to clipboard

CI tests to build notebooks can pass even if notebooks fail

Open jeffjennings opened this issue 1 year ago • 0 comments

prs.yml passes even if processes in bash loop(s) within Makefile fail. These loops should be updated to throw an error when a notebook build or convert (or dependency install) fails.

Fixed with set -e line in bash loops - see ~https://unix.stackexchange.com/a/340652~ https://github.com/orgs/community/discussions/26710

jeffjennings avatar Oct 10 '24 14:10 jeffjennings