astropy-tutorials icon indicating copy to clipboard operation
astropy-tutorials copied to clipboard

New 4 coordinate crossmatch

Open luthienliu opened this issue 3 years ago • 3 comments

  • [x] Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • [x] Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • [x] Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

luthienliu avatar Aug 06 '22 21:08 luthienliu

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hi @luthienliu! Thanks for this PR. It looks like there are some changes to a FITS-tables tutorial in the changes here. Could you please remove those changes from this PR, since I think they are in #564? You'll want to do an interactive rebase to get rid of those commits -- if you aren't sure how to do that, feel free to message me on the Astropy Slack and I can help you through it. Alternatively, I could do the rebase and push to your branch directly -- just let me know what you prefer.

adrn avatar Aug 12 '22 14:08 adrn

Hi again @luthienliu - I went ahead and fixed the merge conflicts for you by rebasing your branch, but in doing that I noticed that you made a new duplicate version of the tutorial instead of modifying the existing 4-Coordinates-Crossmatch.ipynb file. Please copy the proposed changes into that file instead.

adrn avatar Aug 18 '22 02:08 adrn